Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.survey: 3.4.2 -> 3.4.3 #120497

Merged
merged 1 commit into from Apr 24, 2021
Merged

python3Packages.survey: 3.4.2 -> 3.4.3 #120497

merged 1 commit into from Apr 24, 2021

Conversation

SFrijters
Copy link
Member

Motivation for this change

Bugfix release.
Also add version constraint as listed on PyPi.

Things done
$ nixpkgs-review wip
[...]
6 packages updated:
maestral maestral-qt python3.8-maestral python38Packages.survey (3.4.2 → 3.4.3) python3.9-maestral python39Packages.survey (3.4.2 → 3.4.3)
[...]
5 packages built:
maestral maestral-gui python38Packages.survey python39Packages.maestral python39Packages.survey
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 24, 2021 •
edited

Result of nixpkgs-review pr 120497 at 7c5e7d6 run on aarch64-linux 1

5 packages built successfully:
  • maestral (python38Packages.maestral)
  • maestral-gui
  • python38Packages.survey
  • python39Packages.maestral
  • python39Packages.survey

Result of nixpkgs-review pr 120497 at 7c5e7d6 run on x86_64-linux 1

5 packages built successfully:
  • maestral (python38Packages.maestral)
  • maestral-gui
  • python38Packages.survey
  • python39Packages.maestral
  • python39Packages.survey

@fabaff
Copy link
Member

fabaff commented Apr 24, 2021

Result of nixpkgs-review pr 120497 run on x86_64-linux 1

5 packages built:
  • maestral (python38Packages.maestral)
  • maestral-gui
  • python38Packages.survey
  • python39Packages.maestral
  • python39Packages.survey

fabaff
fabaff approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit dae1aca into NixOS:master Apr 24, 2021
@SFrijters SFrijters deleted the python-survey-update branch April 24, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SFrijters @r-rmcgibbo @fabaff