Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyturbojpeg: 1.4.2 -> 1.4.3 #120499

Merged
merged 1 commit into from Apr 24, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://github.com/lilohuang/PyTurboJPEG/releases/tag/v1.4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 24, 2021

Result of nixpkgs-review pr 120499 at a663a7e run on aarch64-linux 1

1 package failed to build:
2 packages built successfully:
  • python38Packages.pyturbojpeg
  • python39Packages.pyturbojpeg
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/python-modules/pyturbojpeg/default.nix:22:5:

       |
    22 |     (substituteAll {
       |     ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 120499 at a663a7e run on x86_64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.pyturbojpeg
  • python39Packages.pyturbojpeg
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/python-modules/pyturbojpeg/default.nix:22:5:

       |
    22 |     (substituteAll {
       |     ^
    

@fabaff
Copy link
Member

fabaff commented Apr 24, 2021

Result of nixpkgs-review pr 120499 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.pyturbojpeg
  • python39Packages.pyturbojpeg

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 1bd1332 into NixOS:master Apr 24, 2021
@dotlambda dotlambda deleted the pyturbojpeg-1.4.3 branch April 24, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants