Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zookeeper: 3.6.2 -> 3.6.3 #120511

Merged
merged 1 commit into from Apr 25, 2021
Merged

zookeeper: 3.6.2 -> 3.6.3 #120511

merged 1 commit into from Apr 25, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2020-25649, CVE-2021-21295, CVE-2021-28165 and CVE-2021-21409.

https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

5 packages built:
  • perl530Packages.NetZooKeeper
  • perl532Packages.NetZooKeeper
  • zkfuse
  • zookeeper
  • zookeeper_mt

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 24, 2021

Result of nixpkgs-review pr 120511 at 10241523 run on x86_64-linux 1

5 packages built successfully:
  • perl530Packages.NetZooKeeper
  • perl532Packages.NetZooKeeper
  • zkfuse
  • zookeeper
  • zookeeper_mt
3 suggestions:
  • warning: unused-argument

    Unused argument: runtimeShell.
    Near pkgs/servers/zookeeper/default.nix:1:61:

      |
    1 | { lib, stdenv, fetchurl, jre, makeWrapper, bash, coreutils, runtimeShell }:
      |                                                             ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/zookeeper/default.nix:17:3:

       |
    17 |   installPhase = ''
       |   ^
    
  • warning: build-tools-in-build-inputs

    pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/zookeeper_mt/default.nix:27:3:

       |
    27 |   buildInputs = [
       |   ^
    

Result of nixpkgs-review pr 120511 at 8495758 run on aarch64-linux 1

5 packages built successfully:
  • perl530Packages.NetZooKeeper
  • perl532Packages.NetZooKeeper
  • zkfuse
  • zookeeper
  • zookeeper_mt

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

Copy link
Contributor

@ztzg ztzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukegb lukegb merged commit 6eb1fc6 into NixOS:master Apr 25, 2021
@LeSuisse LeSuisse deleted the zookeeper-3.7.0 branch April 25, 2021 19:14
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants