New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyfin_10_5: remove unmaintained version #120520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good plan to me.
This version contains a vulnerability[1], and isn't maintained. The original reason to have two jellyfin versions was to allow end-users to backup the database before the layout was upgraded, but these backups should be done periodically. [1]: <https://nvd.nist.gov/vuln/detail/CVE-2021-21402>
0a746d2
to
2ad8aa7
Compare
Do we need a changelog entry? |
It feels a bit weird to add it to the release notes, since it's going to be backported to 20.09 |
Then I would say we only backport the removal of the package, not the change of the module. |
That would mean it would break the config of anyone using Jellyfin and having a stateVersion < 20.09, which would be a shame considering the upgrade should go fine without intervention |
Oh if there's no breaking change in Jellyfin, then this is fine. I just thought a breaking change was why |
This was not really a breaking change, but more of a warning upstream that the database schema would be auto-migrated |
@minijackson Will you make a PR for the backport? |
on it |
Motivation for this change
This version contains a vulnerability, and isn't maintained. The
original reason to have two jellyfin versions was to allow end-users to
backup the database before the layout was upgraded, but these backups
should be done periodically.
Original decision was on #93654, and in retrospect was a mistake, sorry about that.
This PR will be backported if there is no concerns from other maintainers, cc @nyanloutre, @purcell
This is a follow-up on the discussion that started on #120344.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)