Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkvtoolnix: 55.0.0 -> 56.0.0 #120522

Merged
merged 1 commit into from Apr 24, 2021
Merged

mkvtoolnix: 55.0.0 -> 56.0.0 #120522

merged 1 commit into from Apr 24, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Apr 24, 2021

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120522 at 60b30e4 run on x86_64-linux 1

3 packages built successfully:
  • mkvtoolnix
  • mkvtoolnix-cli
  • mpvScripts.convert
3 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/video/mkvtoolnix/default.nix:38:3:

       |
    38 |   installPhase = "drake install -j $NIX_BUILD_CORES";
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/applications/video/mkvtoolnix/default.nix:37:3:

       |
    37 |   buildPhase   = "drake -j $NIX_BUILD_CORES";
       |   ^
    
  • warning: build-tools-in-build-inputs

    qt5.wrapQtAppsHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/video/mkvtoolnix/default.nix:30:3:

       |
    30 |   buildInputs = [
       |   ^
    

@rnhmjoj rnhmjoj merged commit a67aad9 into NixOS:master Apr 24, 2021
@rnhmjoj rnhmjoj deleted the mkvtoolnix branch July 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants