Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sumneko-lua-language-server: darwin support #120527

Closed
wants to merge 1 commit into from
Closed

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Apr 24, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 24, 2021
@mjlbach
Copy link
Contributor

mjlbach commented Apr 25, 2021

My understanding is that this is not going to build until after the 10.12 SDK is bumped to a newer version:

error: builder for '/nix/store/8w6mvlk0sbq0pxvjd7gyb8b5lj31w3rd-sumneko-lua-language-server-1.20.2.drv' failed with exit code 1;
       last 10 log lines:
       >   const auto& vargs = fmt::make_args_checked<Args...>(format_str, args...);
       >                            ^
       > 3rd/bee.lua/bee/fsevent/fsevent_osx.cpp:163:26: note: in instantiation of function template specialization 'fmt::v7::format<char [12], int &, char, 0>' requested here
       >                     fmt::format("remove `{}`", arg.m_id)
       >                          ^
       > 3rd/bee.lua/bee/nonstd/fmt/core.h:1426:41: note: candidate template ignored: invalid explicitly-specified argument for template parameter 'Context'
       > FMT_CONSTEXPR basic_format_arg<Context> make_arg(const T& value) {
       >                                         ^
       > 3 errors generated.
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/8w6mvlk0sbq0pxvjd7gyb8b5lj31w3rd-sumneko-lua-language-server-1.20.2.drv'.

See: LuaLS/lua-language-server#141

@stale
Copy link

stale bot commented Oct 22, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 22, 2021
@malob
Copy link
Member

malob commented Jul 10, 2022

Closing since Darwin support was added in another PR.

@malob malob closed this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants