Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solr: 8.6.3 -> 8.9.0 #120556

Closed
wants to merge 1 commit into from
Closed

solr: 8.6.3 -> 8.9.0 #120556

wants to merge 1 commit into from

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2021-29262, CVE-2021-29943 and CVE-2021-27905.

https://solr.apache.org/security.html#cve-2021-27905-ssrf-vulnerability-with-the-replication-handler
https://solr.apache.org/security.html#cve-2021-29262-misapplied-zookeeper-acls-can-result-in-leakage-of-configured-authentication-and-authorization-settings
https://solr.apache.org/security.html#cve-2021-29943-apache-solr-unprivileged-users-may-be-able-to-perform-unauthorized-readwrite-to-collections

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • solr (solr_8)

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120556 at 5a8899a5 run on x86_64-linux 1

1 package built successfully:
  • solr
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/search/solr/default.nix:14:3:

       |
    14 |   installPhase = ''
       |   ^
    

@lukegb
Copy link
Contributor

lukegb commented Apr 25, 2021

This causes the solr NixOS test to start failing (and it does seem to currently be passing at HEAD: https://hydra.nixos.org/build/141850245/)

@tomberek tomberek mentioned this pull request Apr 26, 2021
@aanderse
Copy link
Member

Does anyone have time to dig into the NixOS test and figure it out? Currently I do not.

Sorry 😔

@LeSuisse
Copy link
Contributor Author

It's a bit strange because the managed-schema file created for the films collection by Solr is assigned 0444 permission. If you just chmod the file with 0644 the test passes perfectly.
I'm not exactly sure what's going on here, I will try to dig further. It might be something obvious to someone used to work with Solr.

@Artturin
Copy link
Member

Artturin commented Aug 8, 2021

8.9.0 is available

@LeSuisse LeSuisse changed the title solr: 8.6.3 -> 8.8.2 solr: 8.6.3 -> 8.9.0 Aug 10, 2021
@LeSuisse
Copy link
Contributor Author

I updated the PR to the 8.9.0 version, the test still fails and I'm still not sure how to solve the issue.

@mohe2015
Copy link
Contributor

Result of nixpkgs-review pr 120556 run on x86_64-linux 1

1 package built:
  • solr

@mohe2015
Copy link
Contributor

SOLR_LOGS_DIR=/tmp solr start -p 49848 claims something started and the admin interface also shows...

@mohe2015
Copy link
Contributor

I think the test fails because it copies some config file (the managed-schema file) from the nixos store and therefore it's read only. It has a creation date of 1970 so I think it's from the nix store.

@LeSuisse
Copy link
Contributor Author

I think you might be right.

The related code section triggering the error in the Solr codebase seems to be https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchema.java#L125-L145. A Git blame on this section does not show something interesting.
We might be able to pinpoint the issue if we determine where in the codebase the file is initially written.

@c0bw3b
Copy link
Contributor

c0bw3b commented Feb 24, 2022

solr is affected by Log4shell vulns up to v8.11.0
https://solr.apache.org/security.html#apache-solr-affected-by-apache-log4j-cve-2021-44228

#150288

@c0bw3b c0bw3b mentioned this pull request Feb 26, 2022
@SuperSandro2000
Copy link
Member

Closing in favor of #161875

@SuperSandro2000 SuperSandro2000 removed the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 26, 2022
@LeSuisse LeSuisse deleted the solr-8.8.2 branch October 26, 2022 23:17
@LeSuisse
Copy link
Contributor Author

Thanks for closing this @SuperSandro2000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants