Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdftk: mark unbroken on darwin #120558

Merged
merged 1 commit into from Apr 25, 2021
Merged

pdftk: mark unbroken on darwin #120558

merged 1 commit into from Apr 25, 2021

Conversation

xworld21
Copy link
Contributor

Motivation for this change

The package started compiling again after #119409 (the upgrade to gradle 7.0; see also #105458 (comment)).

GitHub does not let me revert #105673 which would make sense here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Apr 24, 2021
@lukegb
Copy link
Contributor

lukegb commented Apr 25, 2021

pdftk does indeed build for me on macOS.

@7c6f434c 7c6f434c merged commit a111579 into NixOS:master Apr 25, 2021
@xworld21 xworld21 deleted the pdftk-unmark-broken branch May 3, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@averelld averelld Awaiting requested review from averelld

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xworld21 @lukegb @7c6f434c