Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: chatwoot #120566

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

WIP: chatwoot #120566

wants to merge 7 commits into from

Conversation

mkg20001
Copy link
Member

Motivation for this change

https://github.com/chatwoot/chatwoot on nixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001
Copy link
Member Author

just to summarize my experience with ruby: "what am i even doing anyways"

help greatly appreciated

SuperSandro2000
SuperSandro2000 reviewed Apr 26, 2021
View reviewed changes
pkgs/servers/chatwoot/default.nix
if [ -z "$TARGET" ]; then
TARGET="/run/chatwoot/$1"
fi
rm -rf "$LOCAL"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm -rf "$LOCAL"
rm -r "$LOCAL"

@mkg20001 mkg20001 force-pushed the chatwoot branch 3 times, most recently from b7b6615 to 3c1f7a9 Compare November 3, 2021 02:19
@mkg20001
Copy link
Member Author

mkg20001 commented Nov 3, 2021

currently blocked by fetchYarnDeps bugs

@nh2
Copy link
Contributor

nh2 commented Dec 15, 2021

currently blocked by fetchYarnDeps bugs

@mkg20001 Could you link them?

@mkg20001
Copy link
Member Author

#144200

@mkg20001
Copy link
Member Author

I've pushed an upgrade to chatwoot 2.0.0, this one also triggers the bug

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkg20001 @nh2 @SuperSandro2000 @wegank