Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inetutils: 1.9.4 -> 2.0 #120576

Merged
merged 1 commit into from Aug 26, 2021
Merged

inetutils: 1.9.4 -> 2.0 #120576

merged 1 commit into from Aug 26, 2021

Conversation

wahjava
Copy link
Contributor

@wahjava wahjava commented Apr 25, 2021

  • Remove the already upstream-ed (or not applicable anymore) patches
  • Add patches to update .ORG, and .IN WHOIS servers (submitted upstream)
Motivation for this change

While trying to fix problem related to querying WHOIS server, I noticed available update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

P. S. If maintainer prefers, I'll be happy to help with co-maintaining this derivation.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 25, 2021

Result of nixpkgs-review pr 120576 at a8aab896 run on x86_64-linux 1

16 packages marked as broken and skipped:
  • bareos
  • libvirt_5_9_0
  • linuxPackages-libre.zfs
  • linuxPackages-libre.zfsStable
  • linuxPackages-libre.zfsUnstable
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • linuxPackages_hardkernel_latest.zfsStable
  • ...
4 packages failed to build:
44 packages skipped due to time constraints:
  • ceph (ceph-dev)
  • ceph-client
  • gnome3.gnome-boxes
  • libceph
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages_5_10.zfs ,linuxPackages_5_10.zfsStable)
  • linuxPackages.zfsUnstable (linuxPackages_5_10.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable)
  • linuxPackages_4_19.zfsUnstable
  • ...
42 packages built successfully:
  • collectd
  • collectd-data
  • dnstwist
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-nettool
  • grml-zsh-config
  • gsmartcontrol
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • inetutils
  • libguestfs
  • libvirt
  • libvirt-glib
  • linuxPackages_xen_dom0.zfsUnstable
  • minikube
  • minishift
  • nixopsUnstable
  • partition-manager
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python38Packages.whois
  • python39Packages.guestfs
  • python39Packages.libvirt
  • python39Packages.whois
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_7.ruby-libvirt
  • sanoid
  • smartmontools
  • terraform-providers.libvirt
  • tlp
  • vagrant
  • virt-manager
  • virt-top
  • virt-viewer
  • virtlyst
  • zfs (zfsStable)
  • zfsUnstable
  • zfstools

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 120576 at a8aab896 run on aarch64-linux 1

26 packages marked as broken and skipped:
  • bareos
  • libvirt_5_9_0
  • libvmi
  • linuxPackages-libre.zfs
  • linuxPackages-libre.zfsStable
  • linuxPackages-libre.zfsUnstable
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • ...
24 packages skipped due to time constraints:
  • ceph (ceph-dev)
  • ceph-client
  • gnome3.gnome-boxes
  • libceph
  • linuxPackages.zfsUnstable (linuxPackages_5_10.zfsUnstable ,linuxPackages_xen_dom0.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable)
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable)
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable)
  • linuxPackages_4_4.zfsUnstable
  • ...
41 packages built successfully:
  • collectd
  • collectd-data
  • dnstwist
  • docker-machine-kvm
  • docker-machine-kvm2
  • gnome3.gnome-nettool
  • grml-zsh-config
  • gsmartcontrol
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • inetutils
  • libguestfs
  • libvirt
  • libvirt-glib
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages_5_10.zfs ,linuxPackages_5_10.zfsStable ,linuxPackages_xen_dom0.zfs ,linuxPackages_xen_dom0.zfsStable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_lqx.zfsUnstable
  • linuxPackages_zen.zfsUnstable
  • minikube
  • minishift
  • nixopsUnstable
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python38Packages.whois
  • python39Packages.guestfs
  • python39Packages.libvirt
  • python39Packages.whois
  • sanoid
  • smartmontools
  • terraform-full
  • terraform-providers.libvirt
  • tlp
  • vagrant
  • virt-manager
  • virt-top
  • virt-viewer
  • zfs (zfsStable)
  • zfsUnstable
  • zfstools

- Remove the already upstream-ed (or not applicable anymore) patches
- Add patches to update .ORG, and .IN WHOIS servers (submitted upstream)
- Split name into pname, and version
- Switch to .xz distfile (smaller)
@risicle
Copy link
Contributor

risicle commented Apr 25, 2021

nixpkgs-review happy on nixos x86_64, only build failures pre-existing. Ran various network-related nixos tests successfully too.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 27, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 120576 run on x86_64-linux 1

16 packages marked as broken and skipped:
  • bareos
  • libvirt_5_9_0
  • linuxPackages-libre.zfs
  • linuxPackages-libre.zfsStable
  • linuxPackages-libre.zfsUnstable
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • linuxPackages_hardkernel_latest.zfsStable
  • linuxPackages_hardkernel_latest.zfsUnstable
  • linuxPackages_latest-libre.zfs
  • linuxPackages_latest-libre.zfsStable
  • linuxPackages_latest-libre.zfsUnstable
  • samba4Full
  • sambaFull
8 packages failed to build and already failed to build on hydra master:
  • libvmi: log was empty
  • qemu_xen: log was empty
  • qemu_xen-light: log was empty
  • qubes-core-vchan-xen: log was empty
  • rubyPackages_3_0.ruby-libvirt: log was empty
  • xen: log was empty
  • xen-light: log was empty
  • xen-slim: log was empty
11 packages failed to build and are new build failures:
  • (qemu_xen_4_10): log was empty
  • (qemu_xen_4_10-light): log was empty
  • (xenPackages.xen-vanilla: log was empty
  • ,xenPackages.xen_4_10-vanilla: log was empty
  • ,xen_4_10): log was empty
  • (xenPackages.xen-light: log was empty
  • ,xenPackages.xen_4_10-light: log was empty
  • ,xen_4_10-light): log was empty
  • (xenPackages.xen-slim: log was empty
  • ,xenPackages.xen_4_10-slim: log was empty
  • ,xen_4_10-slim): log was empty
74 packages built:
  • ceph (ceph-dev)
  • ceph-client
  • collectd
  • collectd-data
  • dnstwist
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-boxes
  • gnome3.gnome-nettool
  • grml-zsh-config
  • gsmartcontrol
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • inetutils
  • libceph
  • libguestfs
  • libvirt
  • libvirt-glib
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages_5_10.zfs ,linuxPackages_5_10.zfsStable ,linuxPackages_xen_dom0.zfs ,linuxPackages_xen_dom0.zfsStable)
  • linuxPackages.zfsUnstable (linuxPackages_5_10.zfsUnstable ,linuxPackages_xen_dom0.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable)
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable)
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfs (linuxPackages_4_9.zfsStable)
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_11.zfs (linuxPackages_5_11.zfsStable ,linuxPackages_latest.zfs ,linuxPackages_latest.zfsStable ,linuxPackages_latest_xen_dom0.zfs ,linuxPackages_latest_xen_dom0.zfsStable)
  • linuxPackages_5_11.zfsUnstable (linuxPackages_latest.zfsUnstable ,linuxPackages_latest_xen_dom0.zfsUnstable)
  • linuxPackages_5_4.zfs (linuxPackages_5_4.zfsStable)
  • linuxPackages_5_4.zfsUnstable
  • linuxPackages_hardened.zfs (linuxPackages_hardened.zfsStable ,linuxPackages_xen_dom0_hardened.zfs ,linuxPackages_xen_dom0_hardened.zfsStable)
  • linuxPackages_hardened.zfsUnstable (linuxPackages_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_latest_hardened.zfs (linuxPackages_latest_hardened.zfsStable ,linuxPackages_latest_xen_dom0_hardened.zfs ,linuxPackages_latest_xen_dom0_hardened.zfsStable)
  • linuxPackages_latest_hardened.zfsUnstable (linuxPackages_latest_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_lqx.zfs (linuxPackages_lqx.zfsStable)
  • linuxPackages_lqx.zfsUnstable
  • linuxPackages_testing_bcachefs.zfs (linuxPackages_testing_bcachefs.zfsStable)
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xanmod.zfs (linuxPackages_xanmod.zfsStable)
  • linuxPackages_xanmod.zfsUnstable
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable
  • minikube
  • minishift
  • nixopsUnstable
  • partition-manager
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python38Packages.whois
  • python39Packages.guestfs
  • python39Packages.libvirt
  • python39Packages.whois
  • qemu_full
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_7.ruby-libvirt
  • sanoid
  • smartmontools
  • terraform-full
  • terraform-providers.libvirt
  • tlp
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst
  • zfs (zfsStable)
  • zfsUnstable
  • zfstools

The build failures are probably unrelated because it is all xen which is broken with a lot of kernel modules.

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 120576 run on x86_64-linux 1

16 packages marked as broken and skipped:
  • bareos
  • libvirt_5_9_0
  • linuxPackages-libre.zfs
  • linuxPackages-libre.zfsStable
  • linuxPackages-libre.zfsUnstable
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • linuxPackages_hardkernel_latest.zfsStable
  • linuxPackages_hardkernel_latest.zfsUnstable
  • linuxPackages_latest-libre.zfs
  • linuxPackages_latest-libre.zfsStable
  • linuxPackages_latest-libre.zfsUnstable
  • samba4Full
  • sambaFull
8 packages failed to build:
  • libvmi
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
  • qubes-core-vchan-xen
  • rubyPackages_3_0.ruby-libvirt
  • xen (xenPackages.xen-vanilla ,xenPackages.xen_4_10-vanilla ,xen_4_10)
  • xen-light (xenPackages.xen-light ,xenPackages.xen_4_10-light ,xen_4_10-light)
  • xen-slim (xenPackages.xen-slim ,xenPackages.xen_4_10-slim ,xen_4_10-slim)
74 packages built:
  • ceph (ceph-dev)
  • ceph-client
  • collectd
  • collectd-data
  • dnstwist
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-boxes
  • gnome3.gnome-nettool
  • grml-zsh-config
  • gsmartcontrol
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • inetutils
  • libceph
  • libguestfs
  • libvirt
  • libvirt-glib
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages_5_10.zfs ,linuxPackages_5_10.zfsStable ,linuxPackages_xen_dom0.zfs ,linuxPackages_xen_dom0.zfsStable)
  • linuxPackages.zfsUnstable (linuxPackages_5_10.zfsUnstable ,linuxPackages_xen_dom0.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable)
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable)
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfs (linuxPackages_4_9.zfsStable)
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_11.zfs (linuxPackages_5_11.zfsStable ,linuxPackages_latest.zfs ,linuxPackages_latest.zfsStable ,linuxPackages_latest_xen_dom0.zfs ,linuxPackages_latest_xen_dom0.zfsStable)
  • linuxPackages_5_11.zfsUnstable (linuxPackages_latest.zfsUnstable ,linuxPackages_latest_xen_dom0.zfsUnstable)
  • linuxPackages_5_4.zfs (linuxPackages_5_4.zfsStable)
  • linuxPackages_5_4.zfsUnstable
  • linuxPackages_hardened.zfs (linuxPackages_hardened.zfsStable ,linuxPackages_xen_dom0_hardened.zfs ,linuxPackages_xen_dom0_hardened.zfsStable)
  • linuxPackages_hardened.zfsUnstable (linuxPackages_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_latest_hardened.zfs (linuxPackages_latest_hardened.zfsStable ,linuxPackages_latest_xen_dom0_hardened.zfs ,linuxPackages_latest_xen_dom0_hardened.zfsStable)
  • linuxPackages_latest_hardened.zfsUnstable (linuxPackages_latest_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_lqx.zfs (linuxPackages_lqx.zfsStable)
  • linuxPackages_lqx.zfsUnstable
  • linuxPackages_testing_bcachefs.zfs (linuxPackages_testing_bcachefs.zfsStable)
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xanmod.zfs (linuxPackages_xanmod.zfsStable)
  • linuxPackages_xanmod.zfsUnstable
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable
  • minikube
  • minishift
  • nixopsUnstable
  • partition-manager
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python38Packages.whois
  • python39Packages.guestfs
  • python39Packages.libvirt
  • python39Packages.whois
  • qemu_full
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_7.ruby-libvirt
  • sanoid
  • smartmontools
  • terraform-full
  • terraform-providers.libvirt
  • tlp
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst
  • zfs (zfsStable)
  • zfsUnstable
  • zfstools

@tomberek
Copy link
Contributor

Should this go to staging?

@davidak
Copy link
Member

davidak commented Aug 26, 2021

Should this go to staging?

less than 100 rebuilds is still fine

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@davidak davidak merged commit 8c8cf04 into NixOS:master Aug 26, 2021
@wahjava wahjava deleted the update-inetutils branch August 26, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants