New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethminer: provide a CUDA-free version #120588
Conversation
(cherry picked from commit 3fcdf4e)
Result of 2 packages marked as broken and skipped:
1 package built successfully:
1 suggestion:
|
{ | ||
lib, | ||
stdenv, | ||
clangStdenv, | ||
fetchFromGitHub, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
lib, | |
stdenv, | |
clangStdenv, | |
fetchFromGitHub, | |
{ lib | |
, stdenv | |
, clangStdenv | |
, fetchFromGitHub |
Please format the inputs in this style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we leave style nitpickings on portions I didn't even really touch out of this? Thanks.
If you want to "fix" code style (we don't even have a style guide) feel free to make PRs specific to that purpose (I'd genuinely like that!) but please don't ask me to do that for you in PRs which are not.
I get it, style is important. I try to "fix" sections which I perceive as not conforming to the "norms" when there's a good opportunity (i.e. I'm reworking it in large parts anyways) but you cannot expect people to go out of their way to do that sort of thing where it wouldn't be necessary.
I didn't open ethminer's default.nix and said to myself "Boy golly, I'm going to fix this file's styling!", I opened it to make a functional change with actual value to users.
As a contributor, I see such reviews as entirely unnecessary and even discouraging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to have have derivations buildable without CUDA support as well. LGTM. I added one small suggestion to use cudaSupport
, since it is more standardized in nixpkgs.
CUDA is only needed for Nvidia GPUs; AMD has a fully open stack
Doesn't build on my machine, needs NixOS#109838
@ofborg build ethminer ethminer-cuda ethminer-free |
Motivation for this change
The cuda version is broken and my AMDGPU system doesn't need it to be built with CUDA.
cc @nand0p @noneucat @r-burns @danieldk
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)