Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethminer: provide a CUDA-free version #120588

Merged
merged 6 commits into from Apr 28, 2021
Merged

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Apr 25, 2021

Motivation for this change

The cuda version is broken and my AMDGPU system doesn't need it to be built with CUDA.

cc @nand0p @noneucat @r-burns @danieldk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120588 at 12675a7 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • ethminer
  • ethminer-cuda
1 package built successfully:
  • ethminer-free
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/tools/misc/ethminer/default.nix:83:5:

       |
    83 |     license = licenses.gpl2;
       |     ^
    

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/ethminer/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/ethminer/default.nix Show resolved Hide resolved
Comment on lines 1 to 5
{
lib,
stdenv,
clangStdenv,
fetchFromGitHub,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
lib,
stdenv,
clangStdenv,
fetchFromGitHub,
{ lib
, stdenv
, clangStdenv
, fetchFromGitHub

Please format the inputs in this style.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we leave style nitpickings on portions I didn't even really touch out of this? Thanks.

If you want to "fix" code style (we don't even have a style guide) feel free to make PRs specific to that purpose (I'd genuinely like that!) but please don't ask me to do that for you in PRs which are not.
I get it, style is important. I try to "fix" sections which I perceive as not conforming to the "norms" when there's a good opportunity (i.e. I'm reworking it in large parts anyways) but you cannot expect people to go out of their way to do that sort of thing where it wouldn't be necessary.

I didn't open ethminer's default.nix and said to myself "Boy golly, I'm going to fix this file's styling!", I opened it to make a functional change with actual value to users.

As a contributor, I see such reviews as entirely unnecessary and even discouraging.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to have have derivations buildable without CUDA support as well. LGTM. I added one small suggestion to use cudaSupport, since it is more standardized in nixpkgs.

@danieldk
Copy link
Contributor

@ofborg build ethminer ethminer-cuda ethminer-free

@danieldk danieldk merged commit f9f094e into NixOS:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants