Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf-go: init at 1.26.0 #120593

Closed
wants to merge 1 commit into from
Closed

protobuf-go: init at 1.26.0 #120593

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 25, 2021

Motivation for this change

This is the designated replacement for go-protobuf

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit April 25, 2021 12:34
@raboof
protobuf-go: init at 1.26.0
c9e6a60 
This is the designated replacement of go-protobuf
@raboof raboof force-pushed the go-protobuf-init-at-1.26.0 branch from e394198 to c9e6a60 Compare April 25, 2021 13:27
@raboof raboof requested a review from marsam April 25, 2021 13:27
@marsam
Copy link
Contributor

marsam commented Apr 25, 2021

I realized protobuf-go is already packaged as protoc-gen-go, which seems to be consistent with other repositories https://repology.org/project/protoc-gen-go/versions

@raboof
Copy link
Member Author

raboof commented Apr 25, 2021

I could've sworn I grepped for the github repo name, but apparently not 😆

@raboof raboof closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @marsam