Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.robotframework: 4.0 -> 4.0.1 #120605

Merged
merged 2 commits into from Apr 25, 2021
Merged

python3Packages.robotframework: 4.0 -> 4.0.1 #120605

merged 2 commits into from Apr 25, 2021

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Get the latest bugfixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda requested changes Apr 25, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 0 tests in 0.000s

Please add something like

checkPhase = ''
  ${python.interpreter} utest/run.py
'';

See https://github.com/robotframework/robotframework/tree/master/utest.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 25, 2021 •
edited

Result of nixpkgs-review pr 120605 at 9db80bb run on x86_64-linux 1

6 packages failed to build:
14 packages built successfully:
  • python38Packages.robomachine
  • python38Packages.robotframework
  • python38Packages.robotframework-databaselibrary
  • python38Packages.robotframework-requests
  • python38Packages.robotframework-sshlibrary
  • python38Packages.robotstatuschecker
  • python38Packages.robotsuite
  • python39Packages.robomachine
  • python39Packages.robotframework
  • python39Packages.robotframework-databaselibrary
  • python39Packages.robotframework-requests
  • python39Packages.robotframework-sshlibrary
  • python39Packages.robotstatuschecker
  • python39Packages.robotsuite
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/robotframework/default.nix:14:0:

       |
14 |     description = "Generic test automation framework";
   | ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Result of nixpkgs-review pr 120605 at 9db80bb run on aarch64-linux 1

6 packages failed to build:
14 packages built successfully:
  • python38Packages.robomachine
  • python38Packages.robotframework
  • python38Packages.robotframework-databaselibrary
  • python38Packages.robotframework-requests
  • python38Packages.robotframework-sshlibrary
  • python38Packages.robotstatuschecker
  • python38Packages.robotsuite
  • python39Packages.robomachine
  • python39Packages.robotframework
  • python39Packages.robotframework-databaselibrary
  • python39Packages.robotframework-requests
  • python39Packages.robotframework-sshlibrary
  • python39Packages.robotstatuschecker
  • python39Packages.robotsuite
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/robotframework/default.nix:14:0:

       |
14 |     description = "Generic test automation framework";
   | ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@bjornfor
Copy link
Contributor Author

Ran 0 tests in 0.000s

Please add something like

checkPhase = ''
  ${python.interpreter} utest/run.py
'';

See https://github.com/robotframework/robotframework/tree/master/utest.

It seems the zip-file from PyPi excludes several directories, utest being one of them.

@dotlambda
Copy link
Member

dotlambda commented Apr 25, 2021 •
edited

It seems the zip-file from PyPi excludes several directories, utest being one of them.

Then we should use fetchFromGitHub.

@bjornfor
python3Packages.robotframework: run the unit tests
738e8eb 
The zip-file from PyPI lacks a few directories, notably the one
containing the unit tests. So switch from fetchPypi to fetchFromGitHub.
@bjornfor
Copy link
Contributor Author

It seems the zip-file from PyPi excludes several directories, utest being one of them.

Then we should use fetchFromGitHub.

Done.

@dotlambda dotlambda merged commit a41dc34 into master Apr 25, 2021
@dotlambda dotlambda deleted the update-robotframework branch April 25, 2021 18:22
@dotlambda
Copy link
Member

Thanks a lot!

Btw, you should use a branch in your own fork next time.

@bjornfor
Copy link
Contributor Author

Btw, you should use a branch in your own fork next time.

Oops, I missed/forgot that! (I see you already deleted the branch, thanks.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjornfor @r-rmcgibbo @dotlambda