Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsStatic: don't overwrite openssl version #120608

Closed
wants to merge 1 commit into from
Closed

pkgsStatic: don't overwrite openssl version #120608

wants to merge 1 commit into from

Conversation

Radvendii
Copy link
Contributor

Motivation for this change

Right now pkgsStatic is clobbering the default openssl version, which causes problems when cross-compiling to windows.

This is the expression I'm testing:

with import <nixpkgs> {
  inherit system;
  crossSystem = {
    config = "x86_64-w64-mingw32";
    libc = "msvcrt";
  };

  config = {
    allowUnsupportedSystem = true;
    permittedInsecurePackages = [
      "openssl-1.0.2u"
    ];
  };
  crossOverlays = [(self: super: {
    openssl_1_0_2 = super.openssl_1_0_2.override { withPerl = false; };
  })];
};

pkgsStatic.openssl
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Radvendii
Copy link
Contributor Author

This is moot after #108170. We should probably get rid of openssl_1_0_2 at some point and just have one openssl, at which point it will make sense to restructure this code anyways.

@Radvendii Radvendii closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants