oathToolkit: 2.6.2 -> 2.6.6 #120610
Merged
oathToolkit: 2.6.2 -> 2.6.6 #120610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
added
the
9.needs: maintainer
dotlambda
requested changes
Apr 25, 2021
|
@schnusch Do you wanna be a maintainer for this package? |
dotlambda
requested changes
Apr 25, 2021
Comment on lines
3
to
7
| let | ||
| securityDependency = | ||
| if stdenv.isDarwin then xmlsec | ||
| else pam; | ||
|
|
There was a problem hiding this comment.
Suggested change
| let | |
| securityDependency = | |
| if stdenv.isDarwin then xmlsec | |
| else pam; |
|
|
||
| let | ||
| securityDependency = | ||
| if stdenv.isDarwin then xmlsec | ||
| else pam; | ||
|
|
||
| in stdenv.mkDerivation { | ||
| name = "oath-toolkit-2.6.2"; | ||
| in stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| in stdenv.mkDerivation rec { | |
| stdenv.mkDerivation rec { |
| printf "gdoc_MANS =\ngdoc_TEXINFOS =\n" > libpskc/man/Makefile.gdoc | ||
| touch ChangeLog | ||
| ''; | ||
| buildInputs = [ securityDependency ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ securityDependency ]; | |
| buildInputs = [ (if stdenv.isDarwin then xmlsec else pam) ]; |
|
@SuperSandro2000 That really doesn't make a difference. |
|
It removes a variable which is not required because first I thought securityDepedency is a packageand missing in inputs. Also the beauty of nix of that syntactic changes don't change anything about the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
oath-toolkit-2.6.2 is quite out of date, especially oathtool's syntax to read keys from files is missing.
By building the tarball from https://savannah.nongnu.org/projects/oath-toolkit/ instead of https://gitlab.com/oath-toolkit/oath-toolkit all the changes do not seem necessary anymore.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)