Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpegthumbnailer: use ffmpeg instead of ffmpeg_3 #120611

Merged
merged 1 commit into from Apr 26, 2021
Merged

ffmpegthumbnailer: use ffmpeg instead of ffmpeg_3 #120611

merged 1 commit into from Apr 26, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#94003 and #120372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested review from vs49688 and mtrsk April 25, 2021 16:02
@ofborg ofborg bot requested a review from jagajaga April 25, 2021 16:12
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 25, 2021 •
edited

Result of nixpkgs-review pr 120611 at 9eecf56 run on aarch64-linux 1

4 packages built successfully:
  • ffmpegthumbnailer
  • geeqie
  • spaceFM
  • xfce.tumbler

Result of nixpkgs-review pr 120611 at 9eecf56 run on x86_64-linux 1

4 packages built successfully:
  • ffmpegthumbnailer
  • geeqie
  • spaceFM
  • xfce.tumbler

vs49688
vs49688 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@vs49688 vs49688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. In the future ffmpegthumbnailer itself should be updated to not use deprecated functionality.

@dotlambda
Copy link
Member Author

In the future ffmpegthumbnailer itself should be updated to not use deprecated functionality.

Which functionality are you talking about?

@dotlambda dotlambda merged commit b516dbf into NixOS:master Apr 26, 2021
@dotlambda dotlambda deleted the ffmpegthumbnailer-ffmpeg branch April 26, 2021 08:00
@vs49688
Copy link
Contributor

vs49688 commented Apr 26, 2021

In the future ffmpegthumbnailer itself should be updated to not use deprecated functionality.

Which functionality are you talking about?

Oh, nothing from nixpkgs. I mean internally it uses things like avcodec_decode_video2(), which is long deprecated.

@ghost ghost mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vs49688 vs49688 vs49688 approved these changes

@mtrsk mtrsk mtrsk approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @r-rmcgibbo @vs49688 @mtrsk