protontricks: 1.4.4 -> 1.5.0

[kira-bruneau]

• Update steam-run.patch to support Pressure Vessel runtime
• Fix adding $PROTON_DIST_PATH/lib to LD_LIBRARY_PATH when using legacy runtime
• Use bash instead of /bin/sh now that wrappers are non-POSIX compliant
• Remove test_run_steam_runtime_not_found in steam-run.patch instead of using disabledTests
• Add import check

Motivation for this change

Update to the latest version: https://github.com/Matoking/protontricks/releases/tag/1.5.0 (fixes #119150)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
  • Verified installing libraries with Pressure Vessel container (default behaviour)
  • Verified installing libraries without Pressure Vessel container (--no-bwrap)
  • Verified installing libraries with legacy runtime (forced game to use Proton 4.11-13)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[kira-bruneau]

Result of nixpkgs-review pr 120612 run on x86_64-linux 1

1 package built:

• protontricks

[kira-bruneau]

Sorry for the force-pushes. I noticed that the non-bwrap environment was using the scout runtime from steam-run instead of the runtime specified by the game. With the force-pushes there's less of a difference from upstream now.

[kira-bruneau]

Result of nixpkgs-review pr 120612 run on x86_64-linux 1

1 package built:

• protontricks

[SuperSandro2000]

It would be great for reviewing if the patch was a bit smaller.

[kira-bruneau]

@SuperSandro2000 Hmm, the only changes that are unnecessary are the unused legacy runtime functions that I removed (their purpose is replaced by the fhs environment setup by steam-run). Although, I removed those functions in the previous patch, so keeping them in would make the diff bigger.

The diff probably looks so big because upstream changed so much in 1.5.0. Maybe it would be easier to just look through just the patch file instead of the diff between the old and new patch file?

[kira-bruneau]

One thing I just wanted to mention is that with the steam-run.patch, the legacy runtime library paths are equivalent to the runtime paths used in the use_bwrap environment, so I just renamed the use_bwrap parameter to proton_app_only:

nixpkgs/pkgs/tools/package-management/protontricks/steam-run.patch

Lines 166 to 181 in 27f60ec

	-def get_runtime_library_paths(proton_app, use_bwrap=True):
	+def get_runtime_library_paths(proton_app, proton_app_only=True):
	"""
	Get LD_LIBRARY_PATH value to use when running a command using Steam Runtime
	"""
	@@ -95,7 +77,7 @@ def get_runtime_library_paths(proton_app, use_bwrap=True):
	)
	)
	- if use_bwrap:
	+ if proton_app_only:
	return "".join([
	str(proton_app.proton_dist_path / "lib"), os.pathsep,
	str(proton_app.proton_dist_path / "lib64"), os.pathsep
	@@ -111,14 +93,19 @@ def get_runtime_library_paths(proton_app, use_bwrap=True):
	])

And updated the legacy runtime code path to use get_runtime_library_paths with proton_app_only=True

nixpkgs/pkgs/tools/package-management/protontricks/steam-run.patch

Lines 245 to 250 in 27f60ec

	- # Legacy Steam Runtime requires a different LD_LIBRARY_PATH
	os.environ["PROTON_LD_LIBRARY_PATH"] = \
	- get_legacy_runtime_library_paths(
	- legacy_steam_runtime_path, proton_app
	- )
	+ get_runtime_library_paths(proton_app, proton_app_only=True)