Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punes: init at unstable-2021-04-25 #120618

Merged
merged 1 commit into from Apr 27, 2021

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

Packaging puNES, a Qt-based NES emulator & NSF(e) player.

Bildschirmfoto von 2021-04-25 20-11-13

Marked broken on Darwin because I haven't bothered to test it and the repo doesn't even mention macOS compilation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 25, 2021

Result of nixpkgs-review pr 120618 at e2dba3b7 run on x86_64-linux 1

1 package built successfully:
  • punes
1 suggestion:
  • warning: unnecessary-parallel-building

    Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

    Near pkgs/misc/emulators/punes/default.nix:40:3:

       |
    40 |   enableParallelBuilding = true;
       |   ^
    

Result of nixpkgs-review pr 120618 at e2dba3b7 run on aarch64-linux 1

1 package built successfully:
  • punes

@OPNA2608
Copy link
Contributor Author

  • 1 suggestion:

enableParallelBuilding = true makes a difference here because CMake's special cmakeConfigurePhase is skipped via dontUseCmakeConfigure = true. See jtojnar/nixpkgs-hammering#101.

@fufexan
Copy link
Contributor

fufexan commented Apr 26, 2021

Result of nixpkgs-review pr 120618 run on x86_64-linux 1

1 package built:
  • punes

@OPNA2608
Copy link
Contributor Author

Builds but doesn't run on my Ubuntu machine, I think it's some alsaLib<->system problem and not something I can fix in the packaging?

grafik

@OPNA2608
Copy link
Contributor Author

Gave it an attempt on Darwin and it's definitely neither compatible nor supported. Adjusted platforms & buildInputs accordingly.

@SuperSandro2000 SuperSandro2000 merged commit ecff9e8 into NixOS:master Apr 27, 2021
@OPNA2608 OPNA2608 deleted the init/punes/21.05 branch September 27, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants