Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio: init at 2.7.0 #12062

Merged
merged 3 commits into from Jan 13, 2016
Merged

platformio: init at 2.7.0 #12062

merged 3 commits into from Jan 13, 2016

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Jan 1, 2016

Platformio, http://platformio.org , is a nice tool for managing embedded cross compile toolchians, libraries, and other build tools.

@mogorman mogorman force-pushed the platformio branch 4 times, most recently from 98ec483 to 6607ffb Compare January 2, 2016 01:13
@mogorman
Copy link
Contributor Author

mogorman commented Jan 2, 2016

i dont know why travis failed with collision. this does not happen on my box.

@mogorman mogorman force-pushed the platformio branch 3 times, most recently from bdd66c7 to 7e4de1f Compare January 2, 2016 09:38
@mogorman
Copy link
Contributor Author

mogorman commented Jan 2, 2016

fixed meta support for package thanks to some help from irc

@mogorman mogorman force-pushed the platformio branch 3 times, most recently from 062bba7 to b91fa22 Compare January 2, 2016 14:21
name = "platformio-package-${version}";
version="2.7.0";

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platformio is available via PyPI. I recommend you use that as source instead of GitHub, and also put this expression in python-packages.nix where it belongs.

@FRidh
Copy link
Member

FRidh commented Jan 5, 2016

It didn't fail because of collisions, it failed because of job duration since it was building PyPy interpreter. Is platformio supported with PyPy? If not, please disable it in buildPythonPackage.

@FRidh
Copy link
Member

FRidh commented Jan 5, 2016

Also, I think you should put the changes to buildFHSUserEnv in a separate commit.

@mogorman
Copy link
Contributor Author

mogorman commented Jan 6, 2016

it does compile and run the init function pypy but i havent investigated it much more than that. i wouldnt use it with anything but python2.7. i am making the other change you noted. and im fine making a pull request that depends on another pull request just seemed like a lot of extra work for one small patch

@mogorman mogorman force-pushed the platformio branch 4 times, most recently from 5d6c3e6 to 9cf2c8b Compare January 6, 2016 06:56
@FRidh
Copy link
Member

FRidh commented Jan 6, 2016

A separate PR might not be necessary, but a separate commit is.

@mogorman mogorman force-pushed the platformio branch 2 times, most recently from 847c2b4 to 4e656e1 Compare January 6, 2016 08:52
@mogorman
Copy link
Contributor Author

mogorman commented Jan 6, 2016

3 commits one for each type of work and moved platformio bits into python-packages. also explicitly made it use python2.7 as it wont run the compile command correctly in pypy.

@mogorman
Copy link
Contributor Author

mogorman commented Jan 9, 2016

travis fails due to compile taking to long. it is a good package

@mogorman
Copy link
Contributor Author

@FRidh is anything else needed?

lucabrunox added a commit that referenced this pull request Jan 13, 2016
@lucabrunox lucabrunox merged commit 091c74b into NixOS:master Jan 13, 2016
@lucabrunox
Copy link
Contributor

Built locally, thanks.

@mogorman mogorman deleted the platformio branch January 13, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants