Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftgl: 2.1.3-rc5 -> 2.4.0; cimg: 2.9.6 -> 2.9.7; dialog: 1.3-2210306 -> 1.3-2210324; docutils: 0.16 -> 0.17.1; fme: refactor #120625

Merged
merged 5 commits into from Apr 25, 2021
Merged

ftgl: 2.1.3-rc5 -> 2.4.0; cimg: 2.9.6 -> 2.9.7; dialog: 1.3-2210306 -> 1.3-2210324; docutils: 0.16 -> 0.17.1; fme: refactor #120625

merged 5 commits into from Apr 25, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Apr 25, 2021 •
edited

Motivation for this change

Repology is haunting me (just kidding, I am haunting myself)

ftgl: 2.1.3-rc5 -> 2.4.0;
cimg: 2.9.6 -> 2.9.7;
dialog: 1.3-2210306 -> 1.3-2210324;
docutils: 0.16 -> 0.17.1;
fme: refactor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres changed the title Quick modifications ftgl: 2.1.3-rc5 -> 2.4.0; cimg: 2.9.6 -> 2.9.7; dialog: 1.3-2210306 -> 1.3-2210324; docutils: 0.16 -> 0.17.1; fme: refactor Apr 25, 2021
@ofborg ofborg bot requested review from spacefrogg and lovek323 April 25, 2021 19:10
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120625 at 3482685f run on x86_64-linux 1

885 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
20729 packages skipped due to time constraints:
  • AusweisApp2
  • CHOWTapeModel
  • DisnixWebService
  • EBTKS
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • MACS2
  • MIDIVisualizer
  • MMA
  • OSCAR
  • ...
183 packages built successfully:
  • asciidoctor
  • atk (gnome2.atk ,gnome3.atk)
  • cairo (gnome2.cairo)
  • cimg
  • desktop-file-utils
  • dialog
  • docutils (python38Packages.docutils)
  • fontconfig
  • fontforge (fontforge-fonttools ,python38Packages.fontforge)
  • freeglut
  • ftgl
  • gd
  • gdk-pixbuf
  • gi-docgen
  • glib (gnome2.glib ,gnome3.glib)
  • gtk-doc (gnome2.gtkdoc)
  • gnome2.libIDL
  • pango (gnome2.pango)
  • gobject-introspection (gnome3.gobject-introspection)
  • gsettings-desktop-schemas (gnome3.gsettings-desktop-schemas)
  • gts
  • harfbuzz
  • jpylyzer (python38Packages.jpylyzer)
  • json-glib
  • lasem
  • libass
  • libdrm
  • libnotify
  • libpsl
  • libqrtr-glib
  • perl532Packages.X11Protocol
  • python38Packages.Babel
  • python38Packages.Mako
  • python38Packages.alabaster
  • python38Packages.apipkg
  • python38Packages.astor
  • python38Packages.async_generator
  • python38Packages.automat
  • python38Packages.backcall
  • python38Packages.backports-entry-points-selectable
  • python38Packages.betamax
  • python38Packages.blinker
  • python38Packages.brotli
  • python38Packages.chardet
  • python38Packages.cleo
  • python38Packages.click
  • python38Packages.clikit
  • python38Packages.cloudpickle
  • python38Packages.convertdate
  • python38Packages.ddt
  • python38Packages.django (python38Packages.django_2)
  • python38Packages.entrypoints
  • python38Packages.et_xmlfile
  • python38Packages.execnet
  • python38Packages.flake8
  • python38Packages.flaky
  • python38Packages.flit-core
  • python38Packages.freezegun
  • python38Packages.gunicorn
  • python38Packages.hijri-converter
  • python38Packages.html5lib
  • python38Packages.hyperlink
  • python38Packages.hypothesis
  • python38Packages.idna
  • python38Packages.intreehooks
  • python38Packages.iso8601
  • python38Packages.jdcal
  • python38Packages.jinja2
  • python38Packages.jupyterlab-pygments
  • python38Packages.libevdev
  • python38Packages.m2r
  • python38Packages.mccabe
  • python38Packages.multidict
  • python38Packages.munkres
  • python38Packages.openpyxl
  • python38Packages.pastel
  • python38Packages.pathpy
  • python38Packages.pep517
  • python38Packages.pickleshare
  • python38Packages.psutil
  • python38Packages.py-cpuinfo
  • python38Packages.pyasn1-modules
  • python38Packages.pycairo
  • python38Packages.pydocstyle
  • python38Packages.pygments
  • python38Packages.pygobject3
  • python38Packages.pylama
  • python38Packages.pymeeus
  • python38Packages.pyroma
  • python38Packages.pytest (python38Packages.pytest_6)
  • python38Packages.pytest-asyncio
  • python38Packages.pytest-benchmark
  • python38Packages.pytestcov (python38Packages.pytest-cov)
  • python38Packages.pytest-expect
  • python38Packages.pytest-flake8
  • python38Packages.pytest-forked
  • python38Packages.pytest-freezegun
  • python38Packages.pytest-mock
  • python38Packages.pytestrunner (python38Packages.pytest-runner)
  • python38Packages.pytest-subtests
  • python38Packages.pytest-timeout
  • python38Packages.pytest-xdist (python38Packages.pytest_xdist)
  • python38Packages.pytestCheckHook
  • python38Packages.pytoml
  • python38Packages.requests
  • python38Packages.responses
  • python38Packages.send2trash
  • python38Packages.simplejson
  • python38Packages.smartypants
  • sphinx (python38Packages.sphinx)
  • python38Packages.sqlparse
  • python38Packages.text-unidecode
  • python38Packages.typogrify
  • python38Packages.urllib3
  • python38Packages.webencodings
  • python38Packages.whoosh
  • python38Packages.yarl
  • python39Packages.Babel
  • python39Packages.alabaster
  • python39Packages.apipkg
  • python39Packages.astor
  • python39Packages.async_generator
  • python39Packages.automat
  • python39Packages.backcall
  • python39Packages.backports-entry-points-selectable
  • python39Packages.blinker
  • python39Packages.click
  • python39Packages.cloudpickle
  • python39Packages.ddt
  • python39Packages.docutils
  • python39Packages.entrypoints
  • python39Packages.et_xmlfile
  • python39Packages.execnet
  • python39Packages.flake8
  • python39Packages.flaky
  • python39Packages.flit-core
  • python39Packages.freezegun
  • python39Packages.gunicorn
  • python39Packages.hijri-converter
  • python39Packages.hyperlink
  • python39Packages.idna
  • python39Packages.intreehooks
  • python39Packages.iso8601
  • python39Packages.jdcal
  • python39Packages.jinja2
  • python39Packages.jupyterlab-pygments
  • python39Packages.m2r
  • python39Packages.mccabe
  • python39Packages.multidict
  • python39Packages.openpyxl
  • python39Packages.pastel
  • python39Packages.pathpy
  • python39Packages.pep517
  • python39Packages.pickleshare
  • python39Packages.psutil
  • python39Packages.pyasn1-modules
  • python39Packages.pydocstyle
  • python39Packages.pygments
  • python39Packages.pylama
  • python39Packages.pymeeus
  • python39Packages.pytest (python39Packages.pytest_6)
  • python39Packages.pytest-asyncio
  • python39Packages.pytestcov (python39Packages.pytest-cov)
  • python39Packages.pytest-expect
  • python39Packages.pytest-flake8
  • python39Packages.pytest-forked
  • python39Packages.pytest-freezegun
  • python39Packages.pytest-mock
  • python39Packages.pytestrunner (python39Packages.pytest-runner)
  • python39Packages.pytest-subtests
  • python39Packages.pytestCheckHook
  • python39Packages.pytoml
  • python39Packages.send2trash
  • python39Packages.simplejson
  • python39Packages.sqlparse
  • python39Packages.text-unidecode
  • python39Packages.tzdata
  • python39Packages.webencodings
  • python39Packages.yarl
  • shared-mime-info
  • volk
  • xlibsWrapper (xorg.xlibsWrapper)
  • xorg.libXft
2 suggestions:
  • warning: build-tools-in-build-inputs

    bc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/misc/fme/default.nix:29:3:

       |
29 |   buildInputs = [
   |   ^
  • warning: unused-argument

    Unused argument: isPy38.
    Near pkgs/development/python-modules/docutils/default.nix:5:3:

      |
5 | , isPy38
  |   ^

@AndersonTorres AndersonTorres merged commit b1c9917 into NixOS:master Apr 25, 2021
@zowoq
Copy link
Contributor

zowoq commented Apr 25, 2021

Reverted the docutils bump in fbf8ee0 as it causes a mass rebuild.

@AndersonTorres
Copy link
Member Author

Seriously? Oh man.

@SuperSandro2000
Copy link
Member

Seriously?

Ofborg labeled it like this.

SuperSandro2000
SuperSandro2000 reviewed Apr 27, 2021
View reviewed changes
pkgs/applications/misc/fme/default.nix

stdenv.mkDerivation rec {

pname = "fme";
version = "1.1.3";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub.

pkgs/development/libraries/cimg/default.nix
'';

outputs = [ "out" "doc" ];

meta = with lib; {
homepage = "http://cimg.eu/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirects to https://cimg.eu/.

pkgs/development/python-modules/docutils/default.nix
@@ -30,8 +29,8 @@ buildPythonPackage rec {
'';

meta = with lib; {
description = "Python Documentation Utilities";
homepage = "http://docutils.sourceforge.net/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirects to https://docutils.sourceforge.io/

@AndersonTorres
Copy link
Member Author

Seriously?

Ofborg labeled it like this.

It was a bit surprising.

@AndersonTorres AndersonTorres deleted the quick-modifications branch April 30, 2021 20:51
@romildo romildo mentioned this pull request May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@spacefrogg spacefrogg Awaiting requested review from spacefrogg

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndersonTorres @r-rmcgibbo @zowoq @SuperSandro2000