ombi: 4.0.1292 -> 4.0.1345

[andreisergiu98]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 120637 at df61cb05 run on x86_64-linux 1

1 package built successfully:

• ombi

2 suggestions:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/servers/ombi/default.nix:37:3:

     |
  37 |   installPhase = ''
     |   ^
  

• warning: build-tools-in-build-inputs

  makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/servers/ombi/default.nix:35:3:

     |
  35 |   buildInputs = [ makeWrapper patchelf ];
     |   ^
  

[SuperSandro2000]

@andreabedini please move makeWrapper into nativeBuildInputs.

[andreabedini]

@SuperSandro2000 did you mean to reply to @andreisergiu98 ?

[andreisergiu98]

@andreabedini yep, that's what I think.

@SuperSandro2000 I changed the derivation a little bit. I saw on hydra that it doesn't build on darwin because of patchelf. So I added autoPatchelfHook and fixDarwinDylibNames. I also fixed the test suite because it complained about the default user.