Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mplayer: use ffmpeg instead of ffmpeg_3 #120643

Merged
merged 1 commit into from Apr 27, 2021
Merged

mplayer: use ffmpeg instead of ffmpeg_3 #120643

merged 1 commit into from Apr 27, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#94003 and #120372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from 7c6f434c April 25, 2021 21:03
@ofborg ofborg bot requested a review from edolstra April 25, 2021 21:12
7c6f434c
7c6f434c approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

If @edolstra doesn't object in a few days, feel free to remind me to merge

@ghost ghost mentioned this pull request Apr 26, 2021
Closed
@SuperSandro2000 SuperSandro2000 merged commit daa65fe into NixOS:master Apr 27, 2021
@dotlambda dotlambda deleted the mplayer-ffmpeg branch April 27, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @7c6f434c @SuperSandro2000