Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser-bundle-bin: use ffmpeg instead of ffmpeg_3 #120653

Merged
merged 1 commit into from Apr 27, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#94003 and #120372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using https://senkorasic.com/testmedia/ with pulseaudioSupport enabled:

  • WEBM (24fps, VP9+Opus, 1280x720): video + audio works
  • MP4 (24fps, H.264+AAC, 1280x720): video + audio works
  • HEVC (24fps, H.265+AAC, 1920x1080): audio only (as expected)

Disabling pulseaudioSupport did not affect video playback.

@yoctocell
Copy link
Member

yoctocell commented Apr 26, 2021 via email

@ghost ghost mentioned this pull request Apr 26, 2021
@dotlambda dotlambda merged commit f5f0c3b into NixOS:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants