Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsocket: init at 1.4.29 #120695

Closed
wants to merge 1 commit into from
Closed

gsocket: init at 1.4.29 #120695

wants to merge 1 commit into from

Conversation

tomberek
Copy link
Contributor

Motivation for this change

In case anyone wants it

Things done

package gsocket

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@legendofmiracles
Copy link
Contributor

Result of nixpkgs-review pr 120695 run on x86_64-linux 1

1 package built:
  • gsocket

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120695 at f3ab4109 run on x86_64-linux 1

1 package built successfully:
  • gsocket
2 suggestions:
  • warning: build-tools-in-build-inputs

    autoreconfHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/tools/networking/gsocket/default.nix:14:3:

       |
    14 |   buildInputs = [ autoreconfHook openssl ];
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/tools/networking/gsocket/default.nix:17:3:

       |
    17 |   meta = with lib; {
       |   ^
    

pkgs/tools/networking/gsocket/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/gsocket/default.nix Outdated Show resolved Hide resolved
description = "Connect like there is no firewall, securely";
homepage = "https://www.gsocket.io";
license = licenses.bsd2;
platforms = platforms.unix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a maintainer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any volunteers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not exactly my wheelhouse, but I can fall on that grenade

Suggested change
platforms = platforms.unix;
platforms = platforms.unix;
maintainers = with maintainers; [ urandom ];

@tomberek tomberek changed the title gsocket: init at v1.4.29 gsocket: init at 1.4.29 Apr 26, 2021
@stale
Copy link

stale bot commented Nov 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2021
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Dec 3, 2022
@msm-code msm-code mentioned this pull request Jan 24, 2023
13 tasks
@wegank wegank closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants