Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pylxd: fix build #120704

Merged
merged 2 commits into from Apr 27, 2021
Merged

python3Packages.pylxd: fix build #120704

merged 2 commits into from Apr 27, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from a user April 26, 2021 09:10
@dotlambda dotlambda mentioned this pull request Apr 26, 2021
Merged
10 tasks
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 26, 2021 •
edited

Result of nixpkgs-review pr 120704 at ab3dba9 run on aarch64-linux 1

4 packages built successfully:
  • python38Packages.mock-services
  • python38Packages.pylxd
  • python39Packages.mock-services
  • python39Packages.pylxd

Result of nixpkgs-review pr 120704 at ab3dba9 run on x86_64-linux 1

4 packages built successfully:
  • python38Packages.mock-services
  • python38Packages.pylxd
  • python39Packages.mock-services
  • python39Packages.pylxd

SuperSandro2000
SuperSandro2000 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@dotlambda dotlambda merged commit f21f869 into NixOS:master Apr 27, 2021
@dotlambda dotlambda deleted the pylxd-fix branch April 27, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @r-rmcgibbo @SuperSandro2000