Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug_report.md: remove confusing 'maintainer information' section #120711

Merged
merged 1 commit into from Dec 23, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Apr 26, 2021

Motivation for this change

When I started out, I was confused by this section and no idea what to put in
and I don't think I'm the only one as I rarely see it filled out.

This means there isn't much usefulness in it for bot processing either; better
just remove it.

cc @zimbatm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 30, 2021

Maybe the wording could be updated to just ask the submitter to ping any maintainers / people who have touched that package / module before (guide them to look at git blame / GitHub's UI for that)? I don't typically monitor Nixpkgs issues, so it's helpful for people who have issues with modules or packages of mine to ping me.

@stale
Copy link

stale bot commented Oct 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2021
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I had some ideas with that section but it needs to be generated automatically to be useful and can be re-introduced later if needed.

@Atemu mind updating the PR?

@Atemu
Copy link
Member Author

Atemu commented Oct 31, 2021

Oh! Didn't know there was a conflict, will update it right away.

Can I somehow get github to tell me when that happens again in the future?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 31, 2021
When I started out, I was confused by this section and no idea what to put in
and I don't think I'm the only one as I rarely see it filled out.

This means there isn't much usefulness in it for bot processing either; better
just remove it.
@roberth
Copy link
Member

roberth commented Nov 22, 2021

It didn't confuse me and I think I wrote valid yaml...

Was looking forward to some stats based on the data, but I guess it didn't work out that way.

@zimbatm zimbatm merged commit 0c408a0 into NixOS:master Dec 23, 2021
@zimbatm
Copy link
Member

zimbatm commented Dec 23, 2021

Making a call to remove it. This was a half-assed attempt at collecting package meta-data. Let's re-add it with some proper tooling that can generate the issue template.

@Atemu Atemu deleted the remove-issue-template branch December 23, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants