Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zerotierone: 1.6.4 -> 1.6.5 #120722

Merged
merged 1 commit into from Apr 26, 2021
Merged

zerotierone: 1.6.4 -> 1.6.5 #120722

merged 1 commit into from Apr 26, 2021

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update to latest version: https://github.com/zerotier/ZeroTierOne/releases

Formatted with nixpkgs-fmt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 26, 2021

Result of nixpkgs-review pr 120722 at d4251a8 run on x86_64-linux 1

1 package built successfully:
  • zerotierone
2 suggestions:
  • warning: missing-phase-hooks

    checkPhase should probably contain runHook preCheck and runHook postCheck.

    Near pkgs/tools/networking/zerotierone/default.nix:32:3:

       |
    32 |   checkPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/networking/zerotierone/default.nix:36:3:

       |
    36 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 120722 at d4251a8 run on aarch64-linux 1

1 package built successfully:
  • zerotierone

@zimbatm zimbatm merged commit ec8f6bc into NixOS:master Apr 26, 2021
@ehmry
Copy link
Contributor

ehmry commented Apr 26, 2021

This version finally fixes the "coma" bug that some users have experienced in 1.6.

This should also go to the release branch.

@danielfullmer danielfullmer mentioned this pull request May 2, 2021
10 tasks
@jlesquembre jlesquembre deleted the zerotierone branch June 21, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants