Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clojure: 1.10.3.814 -> 1.10.3.822 #120725

Merged
merged 1 commit into from Apr 27, 2021
Merged

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, LGTM.

Didn't got nixpkgs-review to run on this package since this also updated Lumo (that also needs a full build of Node and takes forever to run).

I did a local testing, and seems fine:

$ ./result/bin/clojure --version
Clojure CLI version 1.10.3.822

$ ./result/bin/clojure
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
Clojure 1.10.3
user=> (+ 1 1)
2
user=>

@thiagokokada
Copy link
Contributor

@GrahamcOfBorg build clojure lumo

@SuperSandro2000 SuperSandro2000 merged commit ce90673 into NixOS:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants