Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: 4.1.1 -> 4.1.2 #120751

Merged
merged 1 commit into from Apr 26, 2021
Merged

electrum: 4.1.1 -> 4.1.2 #120751

merged 1 commit into from Apr 26, 2021

Conversation

eduardosm
Copy link
Contributor

@eduardosm eduardosm commented Apr 26, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eduardosm eduardosm mentioned this pull request Apr 26, 2021
Closed
10 tasks
@ofborg ofborg bot requested review from prusnak, np and joachifm April 26, 2021 16:01
@ofborg ofborg bot requested a review from prusnak April 26, 2021 17:24
@ofborg ofborg bot requested a review from prusnak April 26, 2021 18:01
@prusnak prusnak merged commit d7126a2 into NixOS:master Apr 26, 2021
@prusnak
Copy link
Member

prusnak commented Apr 26, 2021

Thank you!

@eduardosm eduardosm deleted the electrum branch April 26, 2021 18:11
@gruve-p gruve-p mentioned this pull request Feb 2, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@np np Awaiting requested review from np

@joachifm joachifm Awaiting requested review from joachifm

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardosm @prusnak