Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jugglinglab: 1.2.1 -> 1.4.1 [WIP] #120757

Closed
wants to merge 2 commits into from
Closed

Conversation

dschrempf
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dschrempf
Copy link
Contributor Author

Actually, it turns out that the new version uses OR-tools, which seems to be unavailable for Java in NixOS. I guess we need to package OR-tools first...

@dschrempf dschrempf changed the title jugglinglab: 1.2.1 -> 1.4.1 jugglinglab: 1.2.1 -> 1.4.1 [WIP] Apr 26, 2021
@dschrempf dschrempf changed the title jugglinglab: 1.2.1 -> 1.4.1 [WIP] jugglinglab: 1.2.1 -> 1.4.1 Apr 26, 2021
@dschrempf dschrempf changed the title jugglinglab: 1.2.1 -> 1.4.1 jugglinglab: 1.2.1 -> 1.4.1 [WIP] Apr 26, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 26, 2021

Result of nixpkgs-review pr 120757 at 60c8313 run on aarch64-linux 1

1 package failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 120757 at 60c8313 run on x86_64-linux 1

1 package failed to build:
3 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/misc/jugglinglab/default.nix:15:3:

       |
    15 |   installPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/tools/misc/jugglinglab/default.nix:13:3:

       |
    13 |   buildPhase = "ant";
       |   ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/tools/misc/jugglinglab/default.nix:26:7:

       |
    26 |       license = licenses.gpl2;
       |       ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft April 27, 2021 12:53
Comment on lines +3 to 5
version = "1.4.1";
pname = "jugglinglab";
src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.4.1";
pname = "jugglinglab";
src = fetchFromGitHub {
pname = "jugglinglab";
version = "1.4.1";
src = fetchFromGitHub {

@wnklmnn
Copy link
Contributor

wnklmnn commented Apr 27, 2021

Actually, it turns out that the new version uses OR-tools, which seems to be unavailable for Java in NixOS. I guess we need to package OR-tools first...

I've noticed that on aswell. I also naively tried adding 'jkd' and 'maven' to the dependencies of or-tools and adding 'package_java' as a build target. Sadly I does not seem to be that easy :(

nix-build or-tools with jdk and maven
[INFO] Scanning for projects...
[INFO]
[INFO] --------------< com.google.ortools:ortools-linux-x86-64 >---------------
[INFO] Building com.google.ortools:ortools-linux-x86-64 8.1.9999
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-source-plugin/3.2.0/maven-source-plugin-3.2.0.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.247 s
[INFO] Finished at: 2021-04-27T14:29:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Plugin org.apache.maven.plugins:maven-source-plugin:3.2.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-source-plugin:jar:3.2.0: Could not transfer artifact org.apache.maven.plugins:maven-source-plugin:pom:3.2.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-source-plugin/3.2.0/maven-source-plugin-3.2.0.pom: Unknown host repo.maven.apache.org: Name or service not known -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
make: *** [makefiles/Makefile.java.mk:401: temp_java/ortools-linux-x86-64/timestamp] Error 1
make: *** Waiting for unfinished jobs....
builder for '/nix/store/bv0y4zdk9yjy4kwjzndan6wma85lh70a-or-tools-8.1.drv' failed with exit code 2
error: build of '/nix/store/bv0y4zdk9yjy4kwjzndan6wma85lh70a-or-tools-8.1.drv' failed

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/updating-jugglinglab-packaging-a-maven-repository/13726/1

@dschrempf dschrempf closed this Sep 20, 2021
@dschrempf dschrempf deleted the jugginglab branch September 20, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants