r128gain: add unfree derivation to download test files #120788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AluisioASG
force-pushed
the
aasg/test-r128gain
branch
2 times, most recently
from
b5d4194
to
f4b788e
Compare
Comment on lines
34
to
36
| # Testing downloads unredistributable media files for testing, | ||
| # so it's not done by default, but an easy escape hatch is | ||
| # provided . |
There was a problem hiding this comment.
Suggested change
| # Testing downloads unredistributable media files for testing, | |
| # so it's not done by default, but an easy escape hatch is | |
| # provided . | |
| # Testing downloads unredistributable media files for testing, | |
| # so it's not done by default but an easy escape hatch is provided. |
There was a problem hiding this comment.
I decided to rephrase that comment instead to hint at what is needed to run the tests.
r128gain downloads unredistributable media files during testing. After multiple attempts to ease the testing workflow for it, I've settled on providing an unfree derivation that gets built when the user explicitly enables the check phase.
AluisioASG
force-pushed
the
aasg/test-r128gain
branch
from
f4b788e
to
2a8a16d
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r128gain downloads unredistributable media files during testing. After multiple attempts to ease the testing workflow, I've settled on providing an unfree derivation that gets built when the user explicitly enables the check phase (i.e.
nix-build -E '(import ./. {}).r128gain.override { doCheck = true; }').I'm not sure that this is the best way to do it, so I'm looking for feedback.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)