Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.openapi-spec-validator: add missing dependency on openapi-schema-validator #120793

Merged

Conversation

AluisioASG
Copy link
Contributor

Add a new dependency introduced in 0.2.10 (or 0.3.0 since we updated straight to that).

Motivation for this change

Trying to unbreak #120447.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 26, 2021

Result of nixpkgs-review pr 120793 at 2e8fcd22 run on x86_64-linux 1

5 packages failed to build:
10 packages built successfully:
  • python38Packages.apispec
  • python38Packages.openapi-schema-validator
  • python38Packages.openapi-spec-validator
  • python38Packages.prance
  • python38Packages.rfc3339-validator
  • python39Packages.apispec
  • python39Packages.openapi-schema-validator
  • python39Packages.openapi-spec-validator
  • python39Packages.prance
  • python39Packages.rfc3339-validator

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 120793 at 2e8fcd22 run on aarch64-linux 1

5 packages failed to build:
10 packages built successfully:
  • python38Packages.apispec
  • python38Packages.openapi-schema-validator
  • python38Packages.openapi-spec-validator
  • python38Packages.prance
  • python38Packages.rfc3339-validator
  • python39Packages.apispec
  • python39Packages.openapi-schema-validator
  • python39Packages.openapi-spec-validator
  • python39Packages.prance
  • python39Packages.rfc3339-validator

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@AluisioASG
Copy link
Contributor Author

AluisioASG commented Apr 27, 2021

@AluisioASG AluisioASG force-pushed the aasg/openapi-schema-validator branch from 2e8fcd2 to a5a5eea Compare April 27, 2021 13:03
@ofborg ofborg bot requested a review from rvl April 27, 2021 13:13
@AluisioASG AluisioASG mentioned this pull request Apr 27, 2021
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit 815f6ba into NixOS:master Apr 27, 2021
@AluisioASG AluisioASG deleted the aasg/openapi-schema-validator branch April 28, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants