Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glsurf: build with ocaml 4.05 #120799

Merged
merged 3 commits into from Jun 23, 2021
Merged

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Newest officially supported OCaml version it seems. This is in an effort to reduce our dependencies on older sets as much as possible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120799 at fcc9f2ae run on x86_64-linux 1

1 package built successfully:
  • glsurf
3 suggestions:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '+camlp4' doesn't match anything in file 'src/Makefile'
    Near pkgs/applications/science/math/glsurf/default.nix:48:0:

       |
    48 |     description = "A program to draw implicit surfaces and curves";
       | ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/applications/science/math/glsurf/default.nix:46:3:

       |
    46 |   meta = {
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/math/glsurf/default.nix:37:3:

       |
    37 |   installPhase = ''
       |   ^
    

@vbgl
Copy link
Contributor

vbgl commented Apr 27, 2021

Beware of #118934 (already in staging).

@sternenseemann
Copy link
Member Author

Thanks, I vaguely remembered that, but forgot to check if it's in master already. I'll just rebase this on staging.

@sternenseemann sternenseemann changed the base branch from master to staging April 27, 2021 07:53
Version of camlimages which works above OCaml 4.02, but also below 4.06.
Update to somewhat newer OCaml, so we can hopefully retire older sets in
the future.
This was only used for glsurf which no longer needs it.
@sternenseemann
Copy link
Member Author

@ofborg build glsurf

@alyssais alyssais merged commit 17dc76c into NixOS:staging Jun 23, 2021
@sternenseemann sternenseemann deleted the glsurf-ocaml-4.05 branch June 23, 2021 15:18
@sternenseemann
Copy link
Member Author

sternenseemann commented Jun 23, 2021

I probably should've retargeted to master, but it isn't urgent either :)

@sternenseemann sternenseemann restored the glsurf-ocaml-4.05 branch July 24, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants