pipewire: 0.3.25 -> 0.3.26

[talyz]

Motivation for this change

• Update pipewire to the latest version. See the changelog for details.
• Fix the tests
• Add an update script

Things done

• Tested manually

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[legendofmiracles]

Duplicate of #120748

[hmenke]

I suggested to include d393845 in #120748.

[legendofmiracles]

Since now they're on the other PR, can this be closed?

[talyz]

I'd prefer to just rebase this on #120748 and remove the package update, since this now also includes an update script.

[balsoft]

I would be OK with any way to get 0.3.26 in nixpkgs, I just really wanted hardware volume to work :)

If you want to, I can close my PR and just merge yours.

[jansol]

Either PR seems fine (I'm still confused about the hash syntax policy but whatever). The update script is a step in the right direction so that would be nice to have. However a more common case than new config files getting added seems to be that the available keys change, so the tests should also compare found files and warn about differences.

[talyz]

@balsoft Sure, I'm fine either way :)

@jansol I'm not really sure what you mean by that - since the keys are set by the user directly, there isn't much we can do if the schema changes, right? Am I missing something?

[collares]

Clarifying the concern: Suppose upstream edits a config file (not adding a new file, just editing an existing one). Ideally, tests would fail if someone updates pipewire manually (without the update script) and forgets to copy the new files to the NixOS module.

[jansol]

Upstream has renamed config keys that are present in the default config files and will likely do that again in the future. This would make an old unmodified default config no longer work the intended way so it's something I'd like to detect. Users' customized configs are their own problem and the tests aren't concerned with those.

[talyz]

@jansol Well, the installedTests test should show this, right? It enables a "fully featured" pipewire config and runs the test suite - if the default config is severely broken, it should fail. However, the update script should make sure this doesn't happen as often or at all going forward.

[talyz]

Anything more to do here or can we merge?

[jansol]

Works fine on my end, should be good to go.