Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libosmium: 2.16.0 → 2.17.0 #120921

Merged
merged 1 commit into from Apr 30, 2021
Merged

libosmium: 2.16.0 → 2.17.0 #120921

merged 1 commit into from Apr 30, 2021

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Apr 27, 2021

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir requested a review from das-g April 27, 2021 19:10
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 27, 2021 •
edited

Result of nixpkgs-review pr 120921 at bb0df45 run on aarch64-linux 1

3 packages built successfully:
  • osm2pgsql
  • python38Packages.pyosmium
  • python39Packages.pyosmium

Result of nixpkgs-review pr 120921 at bb0df45 run on x86_64-linux 1

5 packages built successfully:
  • libosmium
  • osm2pgsql
  • osmium-tool
  • python38Packages.pyosmium
  • python39Packages.pyosmium

@das-g
Copy link
Member

das-g commented Apr 27, 2021

Result of nixpkgs-review pr 120921 run on x86_64-linux 1

5 packages built:
  • libosmium
  • osm2pgsql
  • osmium-tool
  • python38Packages.pyosmium
  • python39Packages.pyosmium

das-g
das-g approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Change LGMT
👍 Commit LGTM
✔️ tested osm2pgsql --version and osmium --version (they still work and do report the new lib version)

:shipit: Ship it!

pkgs/development/libraries/libosmium/default.nix

src = fetchFromGitHub {
owner = "osmcode";
repo = "libosmium";
rev = "v${version}";
sha256 = "1na51g6xfm1bx0d0izbg99cwmqn0grp0g41znn93xnhs202qnb2h";
sha256 = "sha256-q938WA+vJDqGVutVzWdEP7ujDAmfj3vluliomVd0om0=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another format for the hash? 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nixUnstable generates hash in such format.

@SuperSandro2000 SuperSandro2000 merged commit c47fc06 into NixOS:master Apr 30, 2021
@sikmir sikmir deleted the libosmium branch April 30, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-g das-g das-g approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sikmir @r-rmcgibbo @das-g @SuperSandro2000