Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.requests-http-signature: fix error in tests #120987

Merged
merged 1 commit into from May 12, 2021

Conversation

critbase
Copy link
Contributor

the tests depend on the python package 'cryptography' being present as a dependency. Additionally, cryptography is necessary for some functionality.

Motivation for this change

personal use in a project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 28, 2021

Result of nixpkgs-review pr 120987 at 5ec538f1 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.requests-http-signature
  • python39Packages.requests-http-signature
2 suggestions:
  • warning: duplicate-check-inputs

    Dependencies listed in propagatedBuildInputs should not be repeated in checkInputs.

    Detected duplicates:

    • python3.9-cryptography-3.4.7

    Near pkgs/development/python-modules/requests-http-signature/default.nix:25:3:

       |
    25 |   checkInputs = [ cryptography ];
       |   ^
    

    Near pkgs/development/python-modules/requests-http-signature/default.nix:22:3:

       |
    22 |   propagatedBuildInputs = [ requests ]
       |   ^
    
  • warning: duplicate-check-inputs

    Dependencies listed in propagatedBuildInputs should not be repeated in checkInputs.

    Detected duplicates:

    • python3.8-cryptography-3.4.7

    Near pkgs/development/python-modules/requests-http-signature/default.nix:25:3:

       |
    25 |   checkInputs = [ cryptography ];
       |   ^
    

    Near pkgs/development/python-modules/requests-http-signature/default.nix:22:3:

       |
    22 |   propagatedBuildInputs = [ requests ]
       |   ^
    

Result of nixpkgs-review pr 120987 at 5ec538f1 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.requests-http-signature
  • python39Packages.requests-http-signature
2 suggestions:
  • warning: duplicate-check-inputs

    Dependencies listed in propagatedBuildInputs should not be repeated in checkInputs.

    Detected duplicates:

    • python3.9-cryptography-3.4.7

    Near pkgs/development/python-modules/requests-http-signature/default.nix:25:3:

       |
    25 |   checkInputs = [ cryptography ];
       |   ^
    

    Near pkgs/development/python-modules/requests-http-signature/default.nix:22:3:

       |
    22 |   propagatedBuildInputs = [ requests ]
       |   ^
    
  • warning: duplicate-check-inputs

    Dependencies listed in propagatedBuildInputs should not be repeated in checkInputs.

    Detected duplicates:

    • python3.8-cryptography-3.4.7

    Near pkgs/development/python-modules/requests-http-signature/default.nix:25:3:

       |
    25 |   checkInputs = [ cryptography ];
       |   ^
    

    Near pkgs/development/python-modules/requests-http-signature/default.nix:22:3:

       |
    22 |   propagatedBuildInputs = [ requests ]
       |   ^
    

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets enable it by default to keep things simple.

the tests depend on the python package 'cryptography' being present as a dependency. Additionally, cryptography is necessary for some functionality.
@critbase critbase force-pushed the fix/requests-http-signature branch from 81c9303 to 2fb0413 Compare May 12, 2021 01:41
@critbase
Copy link
Contributor Author

@SuperSandro2000 committed those changes, does this look good now?

@SuperSandro2000 SuperSandro2000 changed the title requests-http-signature: fix error in tests python3Packages.requests-http-signature: fix error in tests May 12, 2021
@SuperSandro2000 SuperSandro2000 merged commit acd49fa into NixOS:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants