Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery-dl: 1.17.1 -> 1.17.3 #120991

Merged
merged 1 commit into from May 9, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for gallery-dl is: "Command-line program to download image-galleries and -collections from several image hosting sites"

meta.homepage for gallery-dl is: "https://github.com/mikf/gallery-dl"

meta.changelog for gallery-dl is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3/bin/gallery-dl passed the binary check.

  • /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3/bin/.gallery-dl-wrapped passed the binary check.

  • 2 of 2 passed binary check by having a zero exit code.

  • 2 of 2 passed binary check by having the new version present in output.

  • found 1.17.3 with grep in /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3

  • found 1.17.3 in filename of file in /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3

  • directory tree listing: https://gist.github.com/d7b5e138858f28b40822d160555829f0

  • du listing: https://gist.github.com/62cfc5e4d90d47732d4533bd04b769fa


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
gallery-dl
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gallery-dl https://github.com/r-ryantm/nixpkgs/archive/59512da201500fdcd4fe1a0aa35c631bdec28a91.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3
ls -la /nix/store/2ac0iar3fjfq4nlcbcbri8hjlk0sv8ny-gallery_dl-1.17.3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • gallery-dl

Maintainer pings

cc @dawidsowa for testing.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 120991 run on x86_64-linux 1

1 package built:
  • gallery-dl

@jonringer jonringer merged commit b8cf417 into NixOS:master May 9, 2021
@r-ryantm r-ryantm deleted the auto-update/gallery_dl branch May 9, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants