Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] steam: fix readonly boostrap.tar.xz #121090

Merged
merged 1 commit into from Apr 28, 2021
Merged

[20.09] steam: fix readonly boostrap.tar.xz #121090

merged 1 commit into from Apr 28, 2021

Conversation

urlordjames
Copy link
Member

steam writes it with 444 permissions, which makes simple deletions fails, and steam will crash

(cherry picked from commit 373cb5d)

Motivation for this change

fix #121025

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

steam writes it with 444 permissions, which makes
simple deletions fails, and steam will crash

(cherry picked from commit 373cb5d)
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 121090 at a8f4cd1 run on x86_64-linux 1

6 packages built successfully:
  • kodiPlugins.steam-launcher
  • lutris
  • steam
  • steam-run
  • steam-run-native
  • steamcmd

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

was able to launch steam

@jonringer jonringer merged commit d2f347c into NixOS:release-20.09 Apr 28, 2021
@jonringer
Copy link
Contributor

thanks for your first contribution to Nixpkgs @urlordjames :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants