Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add which-key-nvim #121092

Merged
merged 2 commits into from Apr 29, 2021
Merged

Add which-key-nvim #121092

merged 2 commits into from Apr 29, 2021

Conversation

pinpox
Copy link
Member

@pinpox pinpox commented Apr 28, 2021

Motivation for this change

Add vimplugin: https://github.com/folke/which-key.nvim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pinpox pinpox requested a review from jonringer as a code owner April 28, 2021 22:11
@pinpox pinpox changed the title Which key nvim Add which-key-nvim Apr 28, 2021
@ofborg ofborg bot requested a review from jorsn April 28, 2021 22:21
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 28, 2021

Result of nixpkgs-review pr 121092 at 5139ef8 run on aarch64-linux 1

1 package failed to build:
3 packages built successfully:
  • spacevim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.vim-hexokinase
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121092 at 5139ef8 run on x86_64-linux 1

1 package failed to build:
64 packages built successfully:
  • spacevim
  • vimPlugins.Coqtail
  • vimPlugins.LeaderF
  • vimPlugins.aniseed
  • vimPlugins.chadtree
  • vimPlugins.coc-nvim
  • vimPlugins.completion-treesitter
  • vimPlugins.conjure
  • vimPlugins.defx-nvim
  • vimPlugins.denite-nvim
  • vimPlugins.deol-nvim
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.embark-vim
  • vimPlugins.galaxyline-nvim
  • vimPlugins.gentoo-syntax
  • vimPlugins.gina-vim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.glow-nvim
  • vimPlugins.julia-vim
  • vimPlugins.lspsaga-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.lush-nvim
  • vimPlugins.neogit
  • vimPlugins.nnn-vim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-bufferline-lua
  • vimPlugins.nvim-dap-virtual-text
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-jdtls
  • vimPlugins.nvim-scrollview
  • vimPlugins.nvim-toggleterm-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.packer-nvim
  • vimPlugins.plenary-nvim
  • vimPlugins.ranger-vim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.telescope-fzf-writer-nvim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.telescope-nvim
  • vimPlugins.telescope-symbols-nvim
  • vimPlugins.telescope-z-nvim
  • vimPlugins.vim-airline
  • vimPlugins.vim-autoformat
  • vimPlugins.vim-bazel
  • vimPlugins.vim-codefmt
  • vimPlugins.vim-flog
  • vimPlugins.vim-go
  • vimPlugins.vim-hexokinase
  • vimPlugins.vim-lsc
  • vimPlugins.vim-lsp
  • vimPlugins.vim-lsp-cxx-highlight
  • vimPlugins.vim-maktaba
  • vimPlugins.vim-matchup
  • vimPlugins.vim-quickrun
  • vimPlugins.vim-rails
  • vimPlugins.vim-tmux-focus-events
  • vimPlugins.vim-tpipeline
  • vimPlugins.vim-wayland-clipboard
  • vimPlugins.vimoutliner
  • vimPlugins.vimtex
  • vimPlugins.vista-vim
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@SuperSandro2000 SuperSandro2000 merged commit cfa0a57 into NixOS:master Apr 29, 2021
@pinpox pinpox deleted the which-key-nvim branch April 29, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants