Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roon-server: 100800753 -> 100800790 #121108

Merged
merged 1 commit into from Apr 29, 2021
Merged

roon-server: 100800753 -> 100800790 #121108

merged 1 commit into from Apr 29, 2021

Conversation

bleggett
Copy link
Contributor

@bleggett bleggett commented Apr 29, 2021 •
edited

Motivation for this change

Update roon-server to current build 790

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bleggett bleggett changed the title Nixos unstable roon-server: 100800753 -> 100800790 Apr 29, 2021
@bleggett bleggett changed the base branch from master to nixos-unstable April 29, 2021 02:04
@ofborg ofborg bot requested a review from lovesegfault April 29, 2021 02:05
@bleggett bleggett changed the base branch from nixos-unstable to master April 29, 2021 02:07
@lovesegfault
Copy link
Member

Please squash your commits and use the standard commit message format:
roon-server: 100800753 -> 100800790

Thanks for the pkg bump!

@bleggett
Copy link
Contributor Author

@lovesegfault done and thanks for adding this in the first place.

@lovesegfault lovesegfault merged commit 8f70383 into NixOS:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bleggett @lovesegfault @Janik-Haag