signal-desktop: 5.0.0 -> 5.1.0

[primeos]

This is the most important Signal-Desktop release in a while as we
finally have Wayland support via Electron 12 \o/ #YAY :D

signalapp/Signal-Desktop#3411

signalapp/Signal-Desktop@5bcf50e#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R231
signalapp/Signal-Desktop@c6d5d85#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R232
https://en.wikipedia.org/wiki/Electron_(software_framework)#Versions

Motivation for this change

Warning: This should use '~/.config/Signal Beta/ but testing this might still cause data-loss!

signal-desktop-beta --enable-features=UseOzonePlatform --ozone-platform=wayland works without XWayland but is also affected by #103049 (which makes sense but is really unfortunate for the Wayland support...). I.e. the 1st launch should be fine but when closing the window and re-launching it no window appears unless --disable-gpu is used, the compositor is restarted, or '~/.config/Signal Beta/ is removed.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[ixmatus]

Will the 21.05 release include this change? If so, then I think this is a risky change for our users. Why not generalize the signal-desktop derivation and produce two, one which is a stable release and the other which is the beta release and allow users to choose if they want the beta release.

[primeos]

@ixmatus oh, no worries, this is only a draft for testing until the next stable release. I should've stated that I won't merge this until then.

Why not generalize the signal-desktop derivation and produce two, one which is a stable release and the other which is the beta release and allow users to choose if they want the beta release.

Yeah, I was surprised how many changes are required to switch to the "beta channel" and might add an abstraction for that so that users could more easily try out beta releases if they want to (but I don't plan on maintaining a signal-desktop-beta in Nixpkgs).

[b12f]

@primeos this dropped officially today! https://github.com/signalapp/Signal-Desktop/releases/tag/v5.1.0

Do you want to continue with this PR? Otherwise I can add my own.

[primeos]

Do you want to continue with this PR?

Yeah, seams reasonable but thanks for the offer :)