libdeltachat: init at 1.54.0 #121151

dotlambda · 2021-04-29T12:27:01Z

Motivation for this change

Things done

~~I could not try KDeltaChat because the interface was unusable for me. Might be that I need to run KDE to test it.~~

link2xt · 2021-04-29T14:35:23Z

I could not try KDeltaChat because the interface was unusable for me. Might be that I need to run KDE to test it.

What does it mean? It does not start or you did not figure out how to use it? There is a menu for account manager where you can create an account, KDE frameworks other than kirigami are not needed.

dotlambda · 2021-04-29T16:48:56Z

What does it mean? It does not start or you did not figure out how to use it? There is a menu for account manager where you can create an account, KDE frameworks other than kirigami are not needed.

Never mind. I just didn't know how to set up an account. What's not working is seeing messages sent from KDeltaChat on the phone, but I guess you haven't implemented that yet?

dotlambda · 2021-04-29T16:54:06Z

Also, hitting Ctrl+Q results in

src/scheduler.rs:120: shutting down inbox loop
src/scheduler.rs:242: shutting down simple loop
src/scheduler.rs:242: shutting down simple loop
src/scheduler.rs:292: shutting down smtp loop
NO MORE EVENTS!
[1]    241522 segmentation fault (core dumped)  ./result/bin/kdeltachat

pkgs/development/python-modules/deltachat/default.nix

pkgs/development/libraries/libdeltachat/default.nix

link2xt · 2021-04-30T05:29:17Z

What's not working is seeing messages sent from KDeltaChat on the phone, but I guess you haven't implemented that yet?

Yes, there is no BCC-self setting on the Settings page yet. But overall, KDeltaChat is pre-alpha, there are many things missing and it sometimes segfaults on exit probably due to deltachat/deltachat-core-rust#2280

SuperSandro2000 · 2021-04-30T10:59:38Z

pkgs/development/libraries/libdeltachat/default.nix

+    homepage = "https://github.com/deltachat/deltachat-core-rust/";
+    changelog = "https://github.com/deltachat/deltachat-core-rust/blob/${version}/CHANGELOG.md";
+    license = licenses.mpl20;
+    maintainers = with maintainers; [ dotlambda ];


Suggested change

maintainers = with maintainers; [ dotlambda ];

maintainers = with maintainers; [ dotlambda ];

# darwin fails with:

# error: failed to add native library /private/tmp/nix-build-libdeltachat-1.52.0.drv-0/source/target/release/build/libsqlite3-sys-e85b24d5407a705c/out/libsqlite3.a: file too small to be an archive

broken = stdenv.isDarwin;

feel free to short the error message.

@SuperSandro2000 Can you try again?

I didn't build it myself. Ofborg did it for me. My builder is currently very flaky and I don't know why so lets wait a bit for ofborg.

I ended up setting platforms = platforms.linux. If someone wants to use it on macOS, feel free to contribute a patch.

dotlambda · 2021-04-30T11:49:26Z

I have no clue how to test whether it's actually using the system libraries.

dotlambda · 2021-04-30T12:37:56Z

@ofborg build python3.pkgs.deltachat python39.pkgs.deltachat

link2xt · 2021-05-02T11:35:57Z

I think you are still using vendored OpenSSL.

Patch deltachat-ffi/Cargo.toml to remove default vendored feature: https://github.com/deltachat/deltachat-core-rust/blob/6971bfc3d4570697fa6b29678e501464cc9deddf/deltachat-ffi/Cargo.toml#L29

This will be fixed in the next version, CMakeLists.txt will disable vendoring for OpenSSL and SQLite.

dotlambda · 2021-05-02T12:17:52Z

I can confirm that system-wide OpenSSL is used now:

$ readelf -d result/lib/libdeltachat.so

Dynamic section at offset 0xf92408 contains 35 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libssl.so.1.1]
 0x0000000000000001 (NEEDED)             Shared library: [libcrypto.so.1.1]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [ld-linux-x86-64.so.2]
 0x000000000000001d (RUNPATH)            Library runpath: [/nix/store/5bg9dy337rp8r1mcc4cdrjwhw1kwmppj-openssl-1.1.1k/lib:/nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib]
...

But it doesn't look like SQLite is.

link2xt · 2021-05-02T13:53:00Z

@dotlambda I have just fixed vendoring on the master branch: deltachat/deltachat-core-rust#2410

Could you try commit deltachat/deltachat-core-rust@8e9d8ae without any patches?

If this works, I think it's easier to wait until the next release, it will be made after deltachat/deltachat-core-rust#2384 is merged.

dotlambda · 2021-05-02T15:06:27Z

@dotlambda I have just fixed vendoring on the master branch: deltachat/deltachat-core-rust#2410

Could you try commit deltachat/deltachat-core-rust@8e9d8ae without any patches?

Nice, it works perfectly:

Dynamic section at offset 0xdda4b8 contains 36 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libssl.so.1.1]
 0x0000000000000001 (NEEDED)             Shared library: [libcrypto.so.1.1]
 0x0000000000000001 (NEEDED)             Shared library: [libsqlite3.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [ld-linux-x86-64.so.2]
 0x000000000000001d (RUNPATH)            Library runpath: [/nix/store/5bg9dy337rp8r1mcc4cdrjwhw1kwmppj-openssl-1.1.1k/lib:/nix/store/dbxrckq9l6lr1s53db6kn4f2rajj766s-sqlite-3.35.2/lib:/nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib]

Thank you so much for looking into this!

If this works, I think it's easier to wait until the next release, it will be made after deltachat/deltachat-core-rust#2384 is merged.

That's what I'll do.

link2xt · 2021-05-03T09:09:12Z

@dotlambda The lastest version tagged 1.54.0 is released: https://github.com/deltachat/deltachat-core-rust/tree/1.54.0

link2xt · 2021-05-03T15:43:14Z

@dotlambda

What's not working is seeing messages sent from KDeltaChat on the phone, but I guess you haven't implemented that yet?

I pushed a commit that adds setting that you need to enable: https://git.sr.ht/~link2xt/kdeltachat/commit/6989af9c746a054dabe24af1210736f464099793

jonringer · 2021-05-03T17:35:54Z

pkgs/development/libraries/libdeltachat/default.nix

+  cargoDeps = rustPlatform.fetchCargoTarball {
+    inherit src;
+    name = "${pname}-${version}";
+    sha256 = "1p5yrhczp9nfijbvkmkmx1rabk5k3c1ni4k1vc0mw4jgl26lslcm";
+  };


just curious as to why rustPlatform.buildRustPackage wasn't used since, it looks like you're running most of the logic.

And maybe just comment as to why buildRustPackage isn't suitable if there is a good reason :)

Cause I'm using CMake. Using buildRustPackage leads to an empty output though I guess I could do make and make install in postBuild and installPhase. I don't see any advantage of that though.

@jonringer Do you know of an easier way?

Ah, I missed that. No, the way that you did it makes sense then :)

github-actions bot added the 6.topic: python label Apr 29, 2021

dotlambda mentioned this pull request Apr 29, 2021

python: fix build against system library deltachat/deltachat-core-rust#2383

Merged

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 29, 2021

dotlambda force-pushed the libdeltachat-init branch from bb925b3 to 59bd3ad Compare April 29, 2021 14:17

dotlambda force-pushed the libdeltachat-init branch from 59bd3ad to ff31887 Compare April 29, 2021 16:53

dotlambda marked this pull request as ready for review April 29, 2021 16:54

dotlambda requested review from FRidh and jonringer as code owners April 29, 2021 16:54

dotlambda force-pushed the libdeltachat-init branch from ff31887 to 95ffa91 Compare April 29, 2021 16:57

dotlambda commented Apr 29, 2021

View reviewed changes

pkgs/development/python-modules/deltachat/default.nix Show resolved Hide resolved

SuperSandro2000 reviewed Apr 29, 2021

View reviewed changes

pkgs/development/libraries/libdeltachat/default.nix Outdated Show resolved Hide resolved

dotlambda force-pushed the libdeltachat-init branch 2 times, most recently from 369f3bc to fcc23c4 Compare April 30, 2021 08:46

SuperSandro2000 reviewed Apr 30, 2021

View reviewed changes

dotlambda force-pushed the libdeltachat-init branch from 1be684e to 809f461 Compare May 2, 2021 11:48

dotlambda force-pushed the libdeltachat-init branch from 809f461 to af564c4 Compare May 2, 2021 15:06

dotlambda marked this pull request as draft May 2, 2021 15:06

dotlambda changed the title ~~libdeltachat: init at 1.52.0~~ libdeltachat: init at 1.54.0 May 3, 2021

libdeltachat: init at 1.54.0

5d8f586

dotlambda force-pushed the libdeltachat-init branch from af564c4 to 250cdec Compare May 3, 2021 09:48

dotlambda marked this pull request as ready for review May 3, 2021 09:48

dotlambda force-pushed the libdeltachat-init branch from 250cdec to 3a0df77 Compare May 3, 2021 13:04

dotlambda added 2 commits May 3, 2021 19:09

kdeltachat: init at unstable-2021-05-03

51aa52a

python3Packages.deltachat: init

8a6ad02

dotlambda force-pushed the libdeltachat-init branch from 3a0df77 to 8a6ad02 Compare May 3, 2021 17:10

dotlambda requested a review from SuperSandro2000 May 3, 2021 17:10

jonringer reviewed May 3, 2021

View reviewed changes

dotlambda merged commit 30c3036 into NixOS:master May 6, 2021

dotlambda deleted the libdeltachat-init branch May 6, 2021 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libdeltachat: init at 1.54.0 #121151

libdeltachat: init at 1.54.0 #121151

dotlambda commented Apr 29, 2021 •

edited

link2xt commented Apr 29, 2021

dotlambda commented Apr 29, 2021

dotlambda commented Apr 29, 2021

link2xt commented Apr 30, 2021

SuperSandro2000 Apr 30, 2021

dotlambda Apr 30, 2021

SuperSandro2000 Apr 30, 2021 •

edited

dotlambda May 2, 2021

dotlambda commented Apr 30, 2021

dotlambda commented Apr 30, 2021

link2xt commented May 2, 2021

dotlambda commented May 2, 2021

link2xt commented May 2, 2021

dotlambda commented May 2, 2021 •

edited

link2xt commented May 3, 2021

link2xt commented May 3, 2021

jonringer May 3, 2021

dotlambda May 3, 2021

dotlambda May 4, 2021

jonringer May 4, 2021

-    maintainers = with maintainers; [ dotlambda ];
+    maintainers = with maintainers; [ dotlambda ];
+    # darwin fails with:
+    # error: failed to add native library /private/tmp/nix-build-libdeltachat-1.52.0.drv-0/source/target/release/build/libsqlite3-sys-e85b24d5407a705c/out/libsqlite3.a: file too small to be an archive
+    broken = stdenv.isDarwin;

libdeltachat: init at 1.54.0 #121151

libdeltachat: init at 1.54.0 #121151

Conversation

dotlambda commented Apr 29, 2021 • edited

Motivation for this change

Things done

link2xt commented Apr 29, 2021

dotlambda commented Apr 29, 2021

dotlambda commented Apr 29, 2021

link2xt commented Apr 30, 2021

SuperSandro2000 Apr 30, 2021

Choose a reason for hiding this comment

dotlambda Apr 30, 2021

Choose a reason for hiding this comment

SuperSandro2000 Apr 30, 2021 • edited

Choose a reason for hiding this comment

dotlambda May 2, 2021

Choose a reason for hiding this comment

dotlambda commented Apr 30, 2021

dotlambda commented Apr 30, 2021

link2xt commented May 2, 2021

dotlambda commented May 2, 2021

link2xt commented May 2, 2021

dotlambda commented May 2, 2021 • edited

link2xt commented May 3, 2021

link2xt commented May 3, 2021

jonringer May 3, 2021

Choose a reason for hiding this comment

dotlambda May 3, 2021

Choose a reason for hiding this comment

dotlambda May 4, 2021

Choose a reason for hiding this comment

jonringer May 4, 2021

Choose a reason for hiding this comment

dotlambda commented Apr 29, 2021 •

edited

SuperSandro2000 Apr 30, 2021 •

edited

dotlambda commented May 2, 2021 •

edited