Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sof-firmware: 1.6 -> 1.7 #121181

Merged
merged 2 commits into from Apr 30, 2021
Merged

sof-firmware: 1.6 -> 1.7 #121181

merged 2 commits into from Apr 30, 2021

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Apr 29, 2021

Motivation for this change

New upstream release: https://github.com/thesofproject/sof-bin/releases/tag/v1.7

Note: The go.sh installation script is broken in the latest release thesofproject/sof-bin#38

Personally, I've been using this for two weeks on NixOS 20.09 without problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hmenke
Copy link
Member Author

hmenke commented Apr 29, 2021

Result of nixpkgs-review pr 121181 1

1 package built:
  • sof-firmware

@hmenke hmenke marked this pull request as ready for review April 29, 2021 18:13
@hmenke
Copy link
Member Author

hmenke commented Apr 29, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Apr 29, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 29, 2021

Result of nixpkgs-review pr 121181 at 8fafda80 run on x86_64-linux 1

1 package built successfully:
  • sof-firmware
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/os-specific/linux/firmware/sof-firmware/default.nix:17:3:

       |
    17 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 121181 at 8fafda80 run on aarch64-linux 1

1 package built successfully:
  • sof-firmware
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/os-specific/linux/firmware/sof-firmware/default.nix:17:3:

       |
    17 |   installPhase = ''
       |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit c9f1544 into NixOS:master Apr 30, 2021
@hmenke hmenke deleted the sof-firmware branch April 30, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants