Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.CoLoR: 1.7.0 → 1.8.1 #121202

Merged
merged 1 commit into from May 6, 2021
Merged

coqPackages.CoLoR: 1.7.0 → 1.8.1 #121202

merged 1 commit into from May 6, 2021

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 29, 2021

Motivation for this change

Support for recent versions of Coq.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl requested review from jwiegley and jpas April 29, 2021 20:31
jpas
jpas approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@jpas jpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbgl
Copy link
Contributor Author

vbgl commented Apr 29, 2021

@GrahamcOfBorg build coqPackages_8_13.CoLoR

@vbgl vbgl merged commit 86878f6 into NixOS:master May 6, 2021
@vbgl vbgl deleted the coq-color-1.8.1 branch May 6, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpas jpas jpas approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @jpas