Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why3: 1.3.3 -> 1.4.0 #121231

Closed
wants to merge 1 commit into from
Closed

why3: 1.3.3 -> 1.4.0 #121231

wants to merge 1 commit into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Apr 30, 2021

Motivation for this change

New release with a lot of updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 30, 2021

Result of nixpkgs-review pr 121231 at 4b8814f3 run on x86_64-linux 1

1 package failed to build:
1 package built successfully:
  • why3
3 suggestions:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern 'js_of_ocaml.ppx' doesn't match anything in file 'Makefile.in'
    Near pkgs/applications/science/logic/why3/default.nix:43:0:

       |
    43 |     description = "A platform for deductive program verification";
       | ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/applications/science/logic/why3/default.nix:1:26:

      |
    1 | { callPackage, fetchurl, fetchpatch, lib, stdenv
      |                          ^
    
  • warning: unclear-gpl

    lgpl21 is a deprecated license, please check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

    Near pkgs/applications/science/logic/why3/default.nix:45:5:

       |
    45 |     license     = licenses.lgpl21;
       |     ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121231 at 4b8814f3 run on aarch64-linux 1

1 package failed to build:
1 package built successfully:
  • why3

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks Frama-C.

@vbgl
Copy link
Contributor

vbgl commented Jun 21, 2021

Frama-C Vanadium is out (rc1). I guess it can be updated in nixpkgs as part of this PR.

@vbgl
Copy link
Contributor

vbgl commented Jun 21, 2021

Also, the postPatch hook should be removed.

@vbgl
Copy link
Contributor

vbgl commented Jul 5, 2021

Subsumed by #128073

@vbgl vbgl closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants