Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: 2.2.15 -> 2.2.16 #121320

Merged
merged 1 commit into from May 1, 2021
Merged

vagrant: 2.2.15 -> 2.2.16 #121320

merged 1 commit into from May 1, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 30, 2021

Motivation for this change

ChangeLog: https://github.com/hashicorp/vagrant/blob/v2.2.16/CHANGELOG.md#2216-april-29-2021

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 30, 2021

Result of nixpkgs-review pr 121320 at ac1ce99 run on aarch64-linux 1

1 package built successfully:
  • vagrant
4 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:57:5:

       |
    57 |     ./0001-Revert-Merge-pull-request-12225-from-chrisroberts-re.patch
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:54:5:

       |
    54 |     ./unofficial-installation-nowarn.patch
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:56:5:

       |
    56 |     ./0004-Support-system-installed-plugins.patch
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:55:5:

       |
    55 |     ./use-system-bundler-version.patch
       |     ^
    

Result of nixpkgs-review pr 121320 at ac1ce99 run on x86_64-linux 1

1 package built successfully:
  • vagrant
4 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:57:5:

       |
    57 |     ./0001-Revert-Merge-pull-request-12225-from-chrisroberts-re.patch
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:56:5:

       |
    56 |     ./0004-Support-system-installed-plugins.patch
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:55:5:

       |
    55 |     ./use-system-bundler-version.patch
       |     ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/vagrant/default.nix:54:5:

       |
    54 |     ./unofficial-installation-nowarn.patch
       |     ^
    

@Ma27 Ma27 merged commit 14ed5fe into NixOS:master May 1, 2021
@Ma27 Ma27 deleted the vagrant-bump branch May 1, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants