Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsvm: 3.24 -> 3.25 #121324

Merged
merged 1 commit into from May 4, 2021
Merged

libsvm: 3.24 -> 3.25 #121324

merged 1 commit into from May 4, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libsvm/versions.

meta.description for libsvm is: "A library for support vector machines"

meta.homepage for libsvm is: "https://www.csie.ntu.edu.tw/~cjlin/libsvm/"

meta.changelog for libsvm is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • Warning: no invocation of /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25/bin/svm-scale had a zero exit code or showed the expected version

  • Warning: no invocation of /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25/bin/svm-train had a zero exit code or showed the expected version

  • Warning: no invocation of /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25/bin/svm-predict had a zero exit code or showed the expected version

  • 0 of 3 passed binary check by having a zero exit code.

  • 0 of 3 passed binary check by having the new version present in output.

  • found 3.25 in filename of file in /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25

  • directory tree listing: https://gist.github.com/789acf83fc10fce8e2f0332c7556a848

  • du listing: https://gist.github.com/b009c9757fde1efbb0346e24719adf7c


Rebuild report (if merged into master) (click to expand)
8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
libsvm
saga
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libsvm https://github.com/r-ryantm/nixpkgs/archive/57c1d572eff6a0b5f6d0509ed351b5b1909f2ab6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25
ls -la /nix/store/xlk2lpyskppbv58y2hkdvxll1kygyi37-libsvm-3.25/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • libsvm
  • saga

Maintainer pings

cc @spwhitt for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 30, 2021

Result of nixpkgs-review pr 121324 at 57c1d57 run on aarch64-linux 1

1 package skipped due to time constraints:
  • saga
1 package built successfully:
  • libsvm
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/libraries/libsvm/default.nix:12:3:

       |
    12 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/libraries/libsvm/default.nix:17:3:

       |
    17 |   installPhase = let
       |   ^
    

Result of nixpkgs-review pr 121324 at 57c1d57 run on x86_64-linux 1

1 package skipped due to time constraints:
  • saga
1 package built successfully:
  • libsvm
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/libraries/libsvm/default.nix:12:3:

       |
    12 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/libraries/libsvm/default.nix:17:3:

       |
    17 |   installPhase = let
       |   ^
    

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldk danieldk merged commit 1d1f719 into NixOS:master May 4, 2021
@r-ryantm r-ryantm deleted the auto-update/libsvm branch May 5, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants