Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsolv: 0.7.17 -> 0.7.19 #121327

Merged
merged 1 commit into from May 9, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libsolv/versions.

meta.description for libsolv is: "A free package dependency solver"

meta.homepage for libsolv is: "https://github.com/openSUSE/libsolv"

meta.changelog for libsolv is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/testsolv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/mergesolv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/dumpsolv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/installcheck passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/rpmdb2solv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/rpms2solv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/repomdxml2solv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/rpmmd2solv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/updateinfoxml2solv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/deltainfoxml2solv passed the binary check.

  • /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin/repo2solv passed the binary check.

  • 10 of 11 passed binary check by having a zero exit code.

  • 11 of 11 passed binary check by having the new version present in output.

  • found 0.7.19 with grep in /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19

  • found 0.7.19 in filename of file in /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19

  • directory tree listing: https://gist.github.com/843ae9b3764e88e822afaeb5e05bfcd6

  • du listing: https://gist.github.com/df1129bcdfa4669e88ec0d1d5e223641


Rebuild report (if merged into master) (click to expand)
15 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
libdnf
libsolv
microdnf
rpm-ostree
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libsolv https://github.com/r-ryantm/nixpkgs/archive/64d3640272a7f8c96e967714b9f30695b73ce691.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19
ls -la /nix/store/nk4kfzw7scj54i6gpm0dcjk039sn613w-libsolv-0.7.19/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • libdnf
  • libsolv
  • microdnf
  • rpm-ostree

Maintainer pings

cc @copumpkin for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 30, 2021

Result of nixpkgs-review pr 121327 at 64d3640 run on aarch64-linux 1

4 packages built successfully:
  • libdnf
  • libsolv
  • microdnf
  • rpm-ostree

Result of nixpkgs-review pr 121327 at 64d3640 run on x86_64-linux 1

4 packages built successfully:
  • libdnf
  • libsolv
  • microdnf
  • rpm-ostree
1 suggestion:
  • warning: build-tools-in-build-inputs

    rpm is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/libsolv/default.nix:23:3:

       |
    23 |   buildInputs = [ zlib expat rpm db ];
       |   ^
    

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 121327 run on x86_64-linux 1

4 packages built:
  • libdnf
  • libsolv
  • microdnf
  • rpm-ostree

@jonringer jonringer merged commit 2502b7c into NixOS:master May 9, 2021
@r-ryantm r-ryantm deleted the auto-update/libsolv branch May 9, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants