Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests: Replace QEMU_OPTS usages with virtualisation.qemu.options #121416

Merged
merged 1 commit into from May 3, 2021
Merged

nixos/tests: Replace QEMU_OPTS usages with virtualisation.qemu.options #121416

merged 1 commit into from May 3, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented May 1, 2021

See 0: "QEMU_OPTS is something that should be set by people running VM
tests interactively, to do port forwardings etc.
We really should not poke with it from the test script - that's what
virtualisation.qemu.options is for."

Co-authored-by: Florian Klink flokli@flokli.de

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos @flokli
nixos/tests: Replace QEMU_OPTS usages with virtualisation.qemu.options
c6325c8 
See [0]: "QEMU_OPTS is something that should be set by people running VM
tests interactively, to do port forwardings etc.
We really should not poke with it from the test script - that's what
virtualisation.qemu.options is for."

[0]: NixOS#119615 (comment)

Co-authored-by: Florian Klink <flokli@flokli.de>
@primeos primeos requested a review from flokli May 1, 2021 18:21
@primeos
Copy link
Member Author

primeos commented May 1, 2021

@GrahamcOfBorg test cage os-prober

@primeos primeos mentioned this pull request May 1, 2021
Merged
10 tasks
@flokli flokli merged commit 9071cb3 into NixOS:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @flokli