Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoxide: 0.6.0 -> 0.7.0 #121455

Merged
merged 1 commit into from May 2, 2021
Merged

zoxide: 0.6.0 -> 0.7.0 #121455

merged 1 commit into from May 2, 2021

Conversation

happysalada
Copy link
Contributor

Motivation for this change

package update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor Author

Result of nixpkgs-review pr 121455 run on x86_64-darwin 1

1 package built:
  • zoxide

@cole-h
Copy link
Member

cole-h commented May 2, 2021

Despite all the checks passing, it would be nice if you had waited on the maintainers to give feedback. I feel like this was a little too fast... I had just opened the email / PR.

@happysalada happysalada deleted the update_zoxide branch May 2, 2021 01:46
@happysalada
Copy link
Contributor Author

Sure, will do for the next one. Since it was a simple update, I thought I wouldn't waste anybody's time.
My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants